Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard copy event and search bar cancellation #5820

Merged
merged 6 commits into from
Mar 4, 2025

Conversation

peterychang
Copy link
Collaborator

@peterychang peterychang commented Mar 4, 2025

Why are these changes needed?

Keyboard focus location was being lost after a copy event. Header anchor was also not selectable while hidden

Fixes (2), (4), (11), (35)

Related issue number

#5630

Checks

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.58%. Comparing base (97536af) to head (adaa213).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5820   +/-   ##
=======================================
  Coverage   75.58%   75.58%           
=======================================
  Files         189      189           
  Lines       12669    12669           
=======================================
  Hits         9576     9576           
  Misses       3093     3093           
Flag Coverage Δ
unittests 75.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rysweet rysweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is custom.js the best filename here?

@peterychang
Copy link
Collaborator Author

is custom.js the best filename here?

Its the default suggested filename (like custom.css)

@peterychang peterychang changed the title Keyboard copy event Keyboard copy event and search bar cancellation Mar 4, 2025
@peterychang peterychang enabled auto-merge (squash) March 4, 2025 18:51
@peterychang peterychang merged commit 92d857f into microsoft:main Mar 4, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants