Adding PR Template #5130
Merged
Adding PR Template #5130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also add "work-item"? |
|
@AdityaMankal-MS I am avoiding that link for now explicitly as this is a public repo. Will have to check with internal Security team first, as links to internal WI will appear here. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Adding a line item to ensure that a work-item is linked to the PR can be considered.
- Helps logically group PRs to ensure continuity and ease of understanding down the lane.
- Helps the reviewer better understand the change.
IMO, this is acceptable from a security standpoint because:
- This repo has already been onboarded to our ADO org and project(s).
- External users will anyhow not be able to access our ADO org and project(s).
|
Added additional details for ADO WI linking. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AdityaMankal-MS
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new PR template to maintain PR hygiene and make it easier to review changes.