Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally use max parallelism value from the client settings API #5132

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

b-barthel
Copy link
Contributor

@b-barthel b-barthel commented Feb 27, 2025

Issue: Currently the default parallelism is set to 192, which is very high for busy machines. This causes timeouts and out of memory errors. There is an existing per-pipeline variable that can override this, but we cannot override the default globally without changing the agent.
Bug 2247830: DownloadPipelineArtifact throws OOMException

Description: This uses our existing client settings API to set the default if it is not overridden on a pipeline level. if the client setting is not available, it remains at the 192 default.

Risk Assesment(Low): We already use client settings for multiple other variables and it is only used if it is set and available and the value is not already overridden.

Added unit tests: (N)

Additional Tests Performed: Manually tested all permutations of pipeline variable override set/not set and client setting set/not set.

@b-barthel b-barthel requested review from a team as code owners February 27, 2025 18:33
@b-barthel
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@b-barthel
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@b-barthel b-barthel merged commit 493c993 into master Mar 5, 2025
20 checks passed
@b-barthel b-barthel deleted the users/b-barthel/ParallelismFromSettingsAPI branch March 5, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants