Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/crescent-credentials
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: microsoft/crescent-credentials
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: jwt-sd3
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 27 files changed
  • 1 contributor

Commits on Feb 13, 2025

  1. Add selective disclosure for JWT credentials

    - Add basic SD example, for FE-sized attribs
    
    - Attributes that are larger than a field element can be hashed to fit,
    then disclosed by revealing the preimage. Completes the core work for
    selective disclosure.  Added support for basic proof specifications
    encoding a description of attribute data to disclose.
    
    - Callers do not have to specify whether a revaled attribute is hashed or
    not, we can figure that out from the config.json file.
    
    - The Groth16 params were being saved twice, once on their own and once in
    the prover params, as they can be large, we only save them once in the
    prover params.
    
    - Add "prepare" option to command line tool, as a synonym for "prove"
    
    Signed-off-by: Greg Zaverucha <gregz@microsoft.com>
    zaverucha committed Feb 13, 2025
    Copy the full SHA
    1e82376 View commit details
  2. Move presentation message into proof spec

    Signed-off-by: Greg Zaverucha <gregz@microsoft.com>
    zaverucha committed Feb 13, 2025
    Copy the full SHA
    de2b970 View commit details
  3. Return Result when creating show proof

    Signed-off-by: Greg Zaverucha <gregz@microsoft.com>
    zaverucha committed Feb 13, 2025
    Copy the full SHA
    365410b View commit details

Commits on Feb 14, 2025

  1. Fix JWT samples after API changes

    Leaves the functionality of the samples unchanged, just upates them to
    use the updated Crescent API.
    
    Signed-off-by: Greg Zaverucha <gregz@microsoft.com>
    zaverucha committed Feb 14, 2025
    Copy the full SHA
    18042c1 View commit details
  2. Clippy fixes

    Signed-off-by: Greg Zaverucha <gregz@microsoft.com>
    zaverucha committed Feb 14, 2025
    Copy the full SHA
    29ee9d3 View commit details

Commits on Feb 19, 2025

  1. Handle presentation message

    - Make it a string in the public ProofSpec, convert to byte array in
      ProofSpecInternal
    - In CLI tool, allow only one, either from command line, or proof spec file
    
    Signed-off-by: Greg Zaverucha <gregz@microsoft.com>
    zaverucha committed Feb 19, 2025
    Copy the full SHA
    30b2635 View commit details
  2. Add rs256-sd to github CI

    Signed-off-by: Greg Zaverucha <gregz@microsoft.com>
    zaverucha committed Feb 19, 2025
    Copy the full SHA
    0b8afb6 View commit details
  3. Move bls12-381 dependency to dev dependencies, currently only used fo…

    …r tests
    
    Signed-off-by: Greg Zaverucha <gregz@microsoft.com>
    zaverucha committed Feb 19, 2025
    Copy the full SHA
    871eb68 View commit details
  4. Update readme explaining selective disclosure functionality

    Signed-off-by: Greg Zaverucha <gregz@microsoft.com>
    zaverucha committed Feb 19, 2025
    Copy the full SHA
    b2424da View commit details

Commits on Feb 20, 2025

  1. Address review comments

    Signed-off-by: Greg Zaverucha <gregz@microsoft.com>
    zaverucha committed Feb 20, 2025
    Copy the full SHA
    b3d47ec View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff main...jwt-sd3