Use alternatives to symlinks on Windows #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianpaquin
requested changes
Dec 11, 2024
zaverucha
requested changes
Dec 12, 2024
sample/setup_service/src/common.rs
Outdated
| @@ -59,11 +59,17 @@ pub fn cred_type_from_schema(schema_uid : &str) -> Result<&'static str, &'static | |||
| use std::os::unix::fs::symlink as symlink_any; | |||
|
|
|||
| #[cfg(windows)] | |||
| use junction; | |||
There was a problem hiding this comment.
By adding use junction; here, the cfg(windows) is no longer applied to symlink_any. (these cfg macros only apply to one line, they aren't blocks. I suggest moving the use junction line back up to the top of the file, with it's own conditional macro.
There was a problem hiding this comment.
(the problem is on linux cargo tries to build symlink_any, which fails)
sample/setup_service/src/common.rs
Outdated
| @@ -59,11 +59,17 @@ pub fn cred_type_from_schema(schema_uid : &str) -> Result<&'static str, &'static | |||
| use std::os::unix::fs::symlink as symlink_any; | |||
There was a problem hiding this comment.
Also could you move lines 58-59 to the top of the file at the same time, thanks.
Signed-off-by: Greg Zaverucha <gregz@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows,
replace directory symlinks with Junctions (junctions are only for directories and require no special privileges)
replace file symlinks with hard-links (hard links are only for files and require no special privileges)