Added presentation message to DL proof generation and validation #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to merge, after fixing CI issue with ark-circom (FYI, @zaverucha) |
Long-term we plan to move to circom-compat in arkworks version 5.0, and this forked code will be removed. Signed-off-by: Greg Zaverucha <gregz@microsoft.com>
zaverucha
requested changes
Jan 24, 2025
| ) { | ||
| let proof_timer = std::time::Instant::now(); | ||
| let paths = CachePaths::new(base_path); | ||
| let io_locations = IOLocations::new(&paths.io_locations); | ||
| let mut client_state: ClientState<CrescentPairing> = read_from_file(&paths.client_state).unwrap(); | ||
| let range_pk : RangeProofPK<CrescentPairing> = read_from_file(&paths.range_pk).unwrap(); | ||
|
|
||
| let pm = presentation_message.as_deref().map(|s| s.as_bytes()); |
There was a problem hiding this comment.
How does pm get defined when presentation_message is None? (same question for line 193)
There was a problem hiding this comment.
pm stays None in that case, and that becomes an empty string in the crypto layer (and the transcript code hashes a [0,0,0,0] length array)
zaverucha
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a presentation message to the DL proof generation and validation process. Addresses part 1 of issue #89.
The presentation message is expected by the
DLogPoKproveandverifyfunctions, which in turn is passed in through the Groth16 show and verify functions.