Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform constraint deserialization in memory #91

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Perform constraint deserialization in memory #91

merged 5 commits into from
Feb 6, 2025

Conversation

ljoy913
Copy link
Collaborator

@ljoy913 ljoy913 commented Jan 24, 2025

  • Read entire constraint section from r1cs file into memory buffer
  • Use cursor to walk through buffer deserializing constraint vectors

zaverucha
zaverucha approved these changes Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@zaverucha zaverucha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You could wait for PR#90 to be merged since it has the fix for warnings that are causing CI to fail.

@ljoy913 ljoy913 merged commit 9c14d22 into main Feb 6, 2025
4 checks passed
@ljoy913 ljoy913 deleted the in-mem-deserialize-constraints branch February 6, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaverucha zaverucha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljoy913 @zaverucha