Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed max_lwt_len to max_cred_len #99

Merged
merged 2 commits into from
Feb 22, 2025
Merged

changed max_lwt_len to max_cred_len #99

merged 2 commits into from
Feb 22, 2025

Conversation

christianpaquin
Copy link
Contributor

Renamed config field max_jwt_len to max_cred_len since it is shared by both cred types.

zaverucha
zaverucha requested changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@zaverucha zaverucha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, just waiting for CI to complete. Also, since we're planning to replace this Python with Rust in the near future let's not invest too much time improving it.

@christianpaquin christianpaquin merged commit 0b6e20a into main Feb 22, 2025
4 checks passed
@christianpaquin christianpaquin deleted the renamed_max_jwt_len branch February 22, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaverucha zaverucha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianpaquin @zaverucha