chore: fix web-components lint setup to avoid leaking rules to json p…

…arser scope
microsoft · Feb 19, 2025 · 0943911 · 0943911
1 parent c3a9a3a
commit 0943911
Showing 2 changed files with 88 additions and 86 deletions.
diff --git a/apps/vr-tests-web-components/.eslintrc.json b/apps/vr-tests-web-components/.eslintrc.json
@@ -1,14 +1,20 @@
 {
   "root": true,
-  "parser": "@typescript-eslint/parser",
-  "plugins": ["@typescript-eslint", "import"],
-  "extends": [
-    "eslint:recommended",
-    "plugin:@typescript-eslint/eslint-recommended",
-    "plugin:@typescript-eslint/recommended",
-    "prettier"
-  ],
-  "rules": {
-    "@typescript-eslint/explicit-module-boundary-types": "off"
-  }
+  "overrides": [
+    {
+      "files": ["src/**/*.{ts,tsx}"],
+      "parser": "@typescript-eslint/parser",
+      "plugins": ["@typescript-eslint", "import"],
+      "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/eslint-recommended",
+        "plugin:@typescript-eslint/recommended",
+        "prettier"
+      ],
+      "rules": {
+        "import/no-extraneous-dependencies": ["error", { "packageDir": [".", "../.."] }],
+        "@typescript-eslint/explicit-module-boundary-types": "off"
+      }
+    }
+  ]
 }
diff --git a/packages/web-components/.eslintrc.json b/packages/web-components/.eslintrc.json
@@ -1,83 +1,79 @@
 {
   "root": true,
-  "parser": "@typescript-eslint/parser",
-  "plugins": ["@typescript-eslint", "import"],
-  "extends": [
-    "eslint:recommended",
-    "plugin:@typescript-eslint/eslint-recommended",
-    "plugin:@typescript-eslint/recommended",
-    "prettier",
-    "plugin:playwright/recommended"
-  ],
-  "settings": {
-    "react": {
-      "version": "latest"
-    }
-  },
-  "rules": {
-    "no-empty": [
-      "error",
-      {
-        "allowEmptyCatch": true
-      }
-    ],
-    "no-extra-boolean-cast": "off",
-    "no-prototype-builtins": "off",
-    "no-fallthrough": "off",
-    "no-unexpected-multiline": "off",
-    "no-useless-escape": "off",
-    "import/order": "error",
-    "sort-imports": [
-      "error",
-      {
-        "ignoreCase": true,
-        "ignoreDeclarationSort": true
-      }
-    ],
-    "comma-dangle": "off",
-    "prefer-const": ["error", { "destructuring": "all" }],
-    "@typescript-eslint/no-non-null-assertion": "off",
-    "@typescript-eslint/no-use-before-define": "off",
-    "@typescript-eslint/no-empty-interface": "error",
-    "@typescript-eslint/no-empty-object-type": "off",
-    "@typescript-eslint/no-unsafe-declaration-merging": "off",
-    "@typescript-eslint/explicit-module-boundary-types": "off",
-    "@typescript-eslint/explicit-function-return-type": "off",
-    "@typescript-eslint/camelcase": "off",
-    "@typescript-eslint/no-inferrable-types": "off",
-    "@typescript-eslint/no-unused-vars": [
-      "warn",
-      {
-        "args": "none"
-      }
-    ],
-    "@typescript-eslint/no-unused-expressions": "warn",
-    "@typescript-eslint/no-explicit-any": "off",
-    "@typescript-eslint/naming-convention": [
-      "error",
-      {
-        "selector": "default",
-        "format": ["UPPER_CASE", "camelCase", "PascalCase"],
-        "leadingUnderscore": "allow"
-      },
-      {
-        "selector": "property",
-        "format": null // disable for property names because of our foo__expanded convention for JSS
-        // TODO: I think we can come up with a regex that ignores variables with __ in them
-      },
-      {
-        "selector": "variable",
-        "format": null // disable for variable names because of our foo__expanded convention for JSS
-        // TODO: I think we can come up with a regex that ignores variables with __ in them
-      }
-    ]
-  },
   "overrides": [
     {
-      "files": ["**/*.json"],
+      "files": ["**/*.{js,ts,tsx}"],
+      "parser": "@typescript-eslint/parser",
+      "plugins": ["@typescript-eslint", "import"],
+      "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/eslint-recommended",
+        "plugin:@typescript-eslint/recommended",
+        "prettier",
+        "plugin:playwright/recommended"
+      ],
+      "settings": {
+        "react": {
+          "version": "latest"
+        }
+      },
       "rules": {
-        "@typescript-eslint/naming-convention": "off",
-        "@typescript-eslint/no-unused-expressions": "off"
+        "no-empty": [
+          "error",
+          {
+            "allowEmptyCatch": true
+          }
+        ],
+        "no-extra-boolean-cast": "off",
+        "no-prototype-builtins": "off",
+        "no-fallthrough": "off",
+        "no-unexpected-multiline": "off",
+        "no-useless-escape": "off",
+        "import/order": "error",
+        "sort-imports": [
+          "error",
+          {
+            "ignoreCase": true,
+            "ignoreDeclarationSort": true
+          }
+        ],
+        "comma-dangle": "off",
+        "prefer-const": ["error", { "destructuring": "all" }],
+        "@typescript-eslint/no-non-null-assertion": "off",
+        "@typescript-eslint/no-use-before-define": "off",
+        "@typescript-eslint/no-empty-interface": "error",
+        "@typescript-eslint/no-empty-object-type": "off",
+        "@typescript-eslint/no-unsafe-declaration-merging": "off",
+        "@typescript-eslint/explicit-module-boundary-types": "off",
+        "@typescript-eslint/explicit-function-return-type": "off",
+        "@typescript-eslint/camelcase": "off",
+        "@typescript-eslint/no-inferrable-types": "off",
+        "@typescript-eslint/no-unused-vars": [
+          "warn",
+          {
+            "args": "none"
+          }
+        ],
+        "@typescript-eslint/no-unused-expressions": "warn",
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/naming-convention": [
+          "error",
+          {
+            "selector": "default",
+            "format": ["UPPER_CASE", "camelCase", "PascalCase"],
+            "leadingUnderscore": "allow"
+          },
+          {
+            "selector": "property",
+            "format": null // disable for property names because of our foo__expanded convention for JSS
+            // TODO: I think we can come up with a regex that ignores variables with __ in them
+          },
+          {
+            "selector": "variable",
+            "format": null // disable for variable names because of our foo__expanded convention for JSS
+            // TODO: I think we can come up with a regex that ignores variables with __ in them
+          }
+        ]
       }
     }
   ]