-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing icons on overflowset v6 #26799
base: 6.0
Are you sure you want to change the base?
Fix missing icons on overflowset v6 #26799
Conversation
This PR is for Fluent UI React 6.X The overflowset custom examples overflow icons are not showing up, this resolves that. tested using the codepen link from the website. https://developer.microsoft.com/en-us/fluentui?fabricVer=6#/controls/web/overflowset
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: fb5f31e3a9fb7d11549ae81c0f0535e1850d071f (build) |
@advancewarsbest please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree |
@micahgodbolt is anything else required, I agreed to the policy and nothing else occurred |
This PR is for Fluent UI React 6.X
Similar as recently submitted PR but for version 7.X and 8.X (Master)
From the developer examples of fluent UI for React, the overflowset custom examples overflow icons are not displaying, this PR resolves it.
tested using the codepen link from the website.
Web page in question link v6:
https://developer.microsoft.com/en-us/fluentui?fabricVer=6#/controls/web/commandbar
NOTE
The code styling in examples of version 6.X use a different styling than 7.X and 8.X, where it uses new lines between iconProps and iconName, so I made the PR in the same style as the rest of 6.X code.
Previous Behavior
the React FluentUI overflowset example does not show the icons that are in the code
New Behavior
Resolves the missing icon issues
Related Issue(s)
None