-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hackathon-2024]: Add Component Selector to storybook #32865
Open
adamsamec
wants to merge
140
commits into
microsoft:master
Choose a base branch
from
adamsamec:adamsamec/component-selector
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[hackathon-2024]: Add Component Selector to storybook #32865
adamsamec
wants to merge
140
commits into
microsoft:master
from
adamsamec:adamsamec/component-selector
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Added styling for headers on page, updated texts, added link icon for the component groups | Added fixed flex layout for the footer so it sticks to the bottom everytime the items are selected
fabricteam
reviewed
Mar 4, 2025
@@ -0,0 +1,52 @@ | |||
import * as React from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual regressions to review in the fluentui-web-components-v3 Visual Regression Report
Badge 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Badge. - Dark Mode.normal.chromium.png | 511 | Changed |
RadioGroup 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
RadioGroup. - Dark Mode.normal.chromium_1.png | 62 | Changed |
Switch 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Switch. - Dark Mode.hover.chromium_2.png | 92 | Changed |
Switch. - Dark Mode.normal.chromium_1.png | 92 | Changed |
TextInput 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
TextInput. - Dark Mode.normal.chromium_1.png | 288 | Changed |
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Mar 6, 2025
@@ -29,7 +29,8 @@ | |||
"prebuildto": "echo '⚠️ NOTE ⚠️:\nThis command is deprecated and will be removed.\nUse nx run <project>:<target> instead'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
Callout 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Callout.No callout width specified.default.chromium.png | 2319 | Changed |
react-charting-LineChart 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
react-charting-LineChart.Gaps.default.chromium.png | 1 | Changed |
react-charting-VerticalBarChart 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png | 4 | Changed |
…msamec/fluentui into adamsamec/component-selector
…msamec/fluentui into adamsamec/component-selector
🕵 fluentuiv9 No visual regressions between this PR and main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
As a 2024 hackathon project, this PR adds the improved version of Component Selector into the storybook. Component Selector is a tool in beta state for developrs and designers that aims to ease the descision process when choosing the right Fluent UI v9 component.
The beta version of Component Selector can be tested here.
Note: Not intended for merge yet
Right now, Component Selector added by this PR is intended only for development and presentation, so the PR is not meant for merge yet.