Skip to content

chore: upgrade typescript to 5.5.2 #33498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

chore: upgrade typescript to 5.5.2 #33498

wants to merge 18 commits into from

Conversation

mainframev
Copy link
Contributor

@mainframev mainframev commented Dec 20, 2024 •
edited
Loading

  • Updates ts to 5.5.2
  • Bumped api-extractor and api-extractor model to the latest (most changes caused by this)
  • Added new @import JSDoc tags.

Release notes

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-4.html
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-5.html

Related to configDir template var: the initial assumption, that it will help to get rid of explicit typeRoots for tsconfig.cy.json files appeared to be wrong. It works for scenarios, where derived config (packages//tsconfig.json) has to have paths related to final directory, before it was needed to re-specify the config property for derived config.

Previous Behavior

5.3.3

New Behavior

5.5.2

Related Issue(s)

Before (5.3.3) After (5.5.2)
12m 20s 12m 37s / 𝚫 2.3% 🐢 SLOWER

(nx run-many -t build type-check --skip-nx-cache)

fabricteam
fabricteam reviewed Dec 20, 2024
View reviewed changes
mainframev
mainframev commented Dec 20, 2024
View reviewed changes
@mainframev mainframev force-pushed the chore/ts-update-5-5 branch 2 times, most recently from 29cadea to ea576b0 Compare December 20, 2024 17:12
mainframev
mainframev commented Dec 20, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Pull request demo site: URL

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library		 1.231 MB
310.272 kB		 1.231 MB
310.275 kB		 4 B
3 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
328 B
global-context
createContextSelector		 537 B
339 B
keyboard-key
keyboard-key package		 3.746 kB
1.928 kB
keyboard-keys
Multiple keyCodes		 50 B
70 B
keyboard-keys
Multiple keys		 87 B
94 B
keyboard-keys
Single key		 44 B
64 B
keyboard-keys
Single keyCode		 39 B
59 B
priority-overflow
createOverflowManager		 4.481 kB
1.864 kB
react
ActivityItem		 71.196 kB
23.345 kB
react
Announced		 38.466 kB
13.274 kB
react
Autofill		 15.42 kB
4.766 kB
react
Breadcrumb		 200.693 kB
59.585 kB
react
Button		 194.242 kB
55.873 kB
react
ButtonGrid		 179.13 kB
53.878 kB
react
Calendar		 121.126 kB
36.821 kB
react
Callout		 84.233 kB
27.586 kB
react
Check		 53.182 kB
17.832 kB
react
Checkbox		 59.948 kB
19.872 kB
react
ChoiceGroup		 65.458 kB
21.462 kB
react
ChoiceGroupOption		 58.745 kB
19.351 kB
react
Coachmark		 92.652 kB
29.303 kB
react
Color		 7.789 kB
3.127 kB
react
ColorPicker		 134.856 kB
42.11 kB
react
ComboBox		 250.575 kB
71.498 kB
react
CommandBar		 201.749 kB
59.376 kB
react
ContextualMenu		 154.117 kB
47.553 kB
react
DatePicker		 183.167 kB
55.873 kB
react
DateTimeUtilities		 5.244 kB
1.849 kB
react
DetailsList		 229.851 kB
65.756 kB
react
Dialog		 210.048 kB
62.348 kB
react
Divider		 19.582 kB
6.838 kB
react
DocumentCard		 215.731 kB
63.643 kB
react
DragDrop		 8.343 kB
2.724 kB
react
DraggableZone		 34.28 kB
11.488 kB
react
Dropdown		 232.997 kB
67.932 kB
react
ExtendedPicker		 96.823 kB
27.867 kB
react
Fabric		 41.722 kB
14.34 kB
react
Facepile		 209.259 kB
62.362 kB
react
FloatingPicker		 240.753 kB
68.209 kB
react
FocusTrapZone		 16.978 kB
5.889 kB
react
FocusZone		 55.1 kB
17.451 kB
react
Grid		 179.13 kB
53.878 kB
react
GroupedList		 135.012 kB
40.665 kB
react
GroupedListV2		 122.629 kB
37.753 kB
react
HoverCard		 96.718 kB
30.685 kB
react
Icon		 51.863 kB
17.261 kB
react
Icons		 66.339 kB
24.386 kB
react
Image		 46.877 kB
15.692 kB
react
Keytip		 81.241 kB
26.671 kB
react
KeytipData		 14.032 kB
4.582 kB
react
KeytipLayer		 103.029 kB
31.896 kB
react
Keytips		 105.801 kB
32.898 kB
react
Label		 38.318 kB
13.239 kB
react
Layer		 48.077 kB
16.346 kB
react
Link		 39.659 kB
13.651 kB
react
List		 39.346 kB
12.454 kB
react
MarqueeSelection		 74.484 kB
22.396 kB
react
MessageBar		 189.276 kB
56.315 kB
react
Modal		 93.678 kB
30.217 kB
react
Nav		 186.713 kB
55.706 kB
react
OverflowSet		 33.336 kB
11.279 kB
react
Overlay		 40.879 kB
14.075 kB
react
Panel		 200.215 kB
59.319 kB
react
Persona		 114.513 kB
36.43 kB
react
PersonaCoin		 114.513 kB
36.43 kB
react
PersonaPresence		 58.052 kB
19.371 kB
react
Pickers		 297.712 kB
82.962 kB
react
Pivot		 187.61 kB
56.481 kB
react
Popup		 12.294 kB
4.195 kB
react
Positioning		 22.764 kB
7.683 kB
react
PositioningContainer		 73.415 kB
23.685 kB
react
ProgressIndicator		 39.471 kB
13.526 kB
react
Rating		 82.056 kB
26.085 kB
react
Fluent UI React (entire library)		 1.019 MB
283.07 kB
react
ResizeGroup		 13.338 kB
4.377 kB
react
ResponsiveMode		 8.13 kB
2.966 kB
react
ScrollablePane		 55.535 kB
17.715 kB
react
SearchBox		 187.512 kB
55.908 kB
react
SelectableOption		 724 B
413 B
react
SelectedItemsList		 231.238 kB
67.163 kB
react
Selection		 42.418 kB
12.26 kB
react
Separator		 35.359 kB
12.13 kB
react
Shimmer		 49.237 kB
16.255 kB
react
ShimmeredDetailsList		 240.633 kB
68.511 kB
react
Slider		 57.615 kB
19.194 kB
react
SpinButton		 191.185 kB
56.991 kB
react
Spinner		 41.753 kB
14.466 kB
react
Stack		 42.03 kB
14.386 kB
react
Sticky		 32.577 kB
10.488 kB
react
Styling		 46.033 kB
15.135 kB
react
SwatchColorPicker		 189.525 kB
57.405 kB
react
TeachingBubble		 204.527 kB
60.294 kB
react
Text		 36.886 kB
12.806 kB
react
TextField		 80.768 kB
25.3 kB
react
Theme		 43.486 kB
14.168 kB
react
ThemeGenerator		 12.384 kB
4.116 kB
react
TimePicker		 240.403 kB
69.296 kB
react
Toggle		 46.189 kB
15.954 kB
react
Tooltip		 87.013 kB
28.144 kB
react
Utilities		 82.932 kB
25.149 kB
react
Viewport		 23.872 kB
7.642 kB
react
WeeklyDayPicker		 101.318 kB
31.637 kB
react
WindowProvider		 1.059 kB
541 B
react-accordion
Accordion (including children components)		 108.02 kB
33.15 kB
react-aria
ARIA - Default		 237 B
181 B
react-avatar
Avatar		 49.376 kB
15.835 kB
react-avatar
AvatarGroup		 20.177 kB
7.974 kB
react-avatar
AvatarGroupItem		 63.52 kB
20.047 kB
react-badge
Badge		 26.002 kB
8.603 kB
react-badge
CounterBadge		 26.781 kB
8.882 kB
react-badge
PresenceBadge		 25.789 kB
9.472 kB
react-breadcrumb
@fluentui/react-breadcrumb - package		 115.069 kB
31.86 kB
react-button
Button		 37.648 kB
10.867 kB
react-button
CompoundButton		 44.059 kB
12.168 kB
react-button
MenuButton		 42.457 kB
12.216 kB
react-button
SplitButton		 50.527 kB
13.782 kB
react-button
ToggleButton		 53.578 kB
12.642 kB
react-calendar-compat
Calendar Compat		 149.673 kB
39.915 kB
react-card
Card - All		 102.52 kB
28.908 kB
react-card
Card		 95.162 kB
27.094 kB
react-card
CardFooter		 14.605 kB
5.885 kB
react-card
CardHeader		 17.138 kB
6.751 kB
react-card
CardPreview		 14.671 kB
6.009 kB
react-checkbox
Checkbox		 35.189 kB
12.093 kB
react-color-picker
ColorArea		 50.26 kB
17.664 kB
react-color-picker
ColorPicker		 18.893 kB
7.495 kB
react-color-picker
ColorSlider		 42.436 kB
15.715 kB
react-combobox
Combobox (including child components)		 107.617 kB
35.006 kB
react-combobox
Dropdown (including child components)		 108.241 kB
34.952 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 69.732 kB
20.259 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 227.58 kB
65.885 kB
react-components
react-components: FluentProvider & webLightTheme		 44.567 kB
14.62 kB
react-datepicker-compat
DatePicker Compat		 227.32 kB
64.366 kB
react-dialog
Dialog (including children components)		 102.547 kB
30.738 kB
react-divider
Divider		 21.399 kB
7.964 kB
react-field
Field		 23.515 kB
8.917 kB
react-image
Image		 15.432 kB
6.251 kB
react-input
Input		 28.085 kB
9.456 kB
react-jsx-runtime
Classic Pragma		 1.101 kB
550 B
react-jsx-runtime
JSX Dev Runtime		 3.815 kB
1.659 kB
react-jsx-runtime
JSX Runtime		 4.411 kB
1.901 kB
react-label
Label		 14.742 kB
6.007 kB
react-link
Link		 17.671 kB
7.155 kB
react-list
List		 89.684 kB
26.704 kB
react-list
ListItem		 113.027 kB
33.481 kB
react-menu
Menu (including children components)		 157.228 kB
47.266 kB
react-menu
Menu (including selectable components)		 160.21 kB
47.87 kB
react-message-bar
MessageBar (all components)		 24.948 kB
9.289 kB
react-motion
@fluentui/react-motion - createMotionComponent()		 3.995 kB
1.755 kB
react-motion
@fluentui/react-motion - createPresenceComponent()		 4.858 kB
2.128 kB
react-motion
@fluentui/react-motion - PresenceGroup		 1.727 kB
823 B
react-northstar
Accordion		 85.349 kB
26.59 kB
react-northstar
Alert		 87.403 kB
27.007 kB
react-northstar
Animation		 55.321 kB
17.925 kB
react-northstar
Attachment		 86.798 kB
26.786 kB
react-northstar
Avatar		 80.212 kB
24.722 kB
react-northstar
Box		 75.199 kB
23.887 kB
react-northstar
Breadcrumb		 79.874 kB
24.761 kB
react-northstar
Button		 83.113 kB
26.039 kB
react-northstar
Card		 82.648 kB
25.128 kB
react-northstar
Carousel		 105.135 kB
31.991 kB
react-northstar
Chat		 154.041 kB
46.993 kB
react-northstar
Checkbox		 79.743 kB
25.178 kB
react-northstar
Datepicker		 185.911 kB
56.955 kB
react-northstar
Debug		 8.801 kB
3.595 kB
react-northstar
Design		 36.579 kB
12.169 kB
react-northstar
Dialog		 112.024 kB
33.699 kB
react-northstar
Divider		 76.552 kB
24.203 kB
react-northstar
Dropdown		 198.154 kB
60.266 kB
react-northstar
Embed		 81.434 kB
25.518 kB
react-northstar
Flex		 47.702 kB
15.515 kB
react-northstar
Form		 92.484 kB
28.981 kB
react-northstar
Grid		 70.533 kB
22.346 kB
react-northstar
Header		 74.709 kB
23.565 kB
react-northstar
Image		 73.524 kB
23.403 kB
react-northstar
Input		 88.303 kB
27.904 kB
react-northstar
ItemLayout		 78.184 kB
24.52 kB
react-northstar
Label		 77.86 kB
24.51 kB
react-northstar
Layout		 75.345 kB
23.863 kB
react-northstar
List		 88.433 kB
27.704 kB
react-northstar
Loader		 78.568 kB
24.846 kB
react-northstar
Menu		 128.544 kB
40.789 kB
react-northstar
MenuButton		 162.956 kB
49.786 kB
react-northstar
Pill		 83.676 kB
26.177 kB
react-northstar
Popup		 135.262 kB
42.303 kB
react-northstar
Portal		 58.282 kB
18.951 kB
react-northstar
Provider		 93.081 kB
29.694 kB
react-northstar
RadioGroup		 83.229 kB
26.16 kB
react-northstar
Reaction		 77.231 kB
24.226 kB
react-northstar
Segment		 76.161 kB
23.977 kB
react-northstar
Skeleton		 77.719 kB
24.278 kB
react-northstar
Slider		 84.222 kB
26.834 kB
react-northstar
SplitButton		 178.194 kB
53.593 kB
react-northstar
Status		 76.224 kB
24.159 kB
react-northstar
SvgIcon		 36.797 kB
11.774 kB
react-northstar
Table		 80.752 kB
25.246 kB
react-northstar
Text		 73.999 kB
23.623 kB
react-northstar
TextArea		 74.201 kB
23.59 kB
react-northstar
Toolbar		 174.757 kB
52.981 kB
react-northstar
Tooltip		 109.909 kB
35.316 kB
react-northstar
Tree		 87.809 kB
27.301 kB
react-northstar
Video		 75.367 kB
23.861 kB
react-overflow
hooks only		 12.832 kB
4.828 kB
react-persona
Persona		 56.267 kB
17.712 kB
react-popover
Popover		 132.988 kB
41.417 kB
react-portal
Portal		 15.259 kB
5.319 kB
react-portal-compat
PortalCompatProvider		 8.386 kB
2.624 kB
react-positioning
usePositioning		 28.865 kB
10.146 kB
react-positioning
useSafeZoneArea		 12.202 kB
4.672 kB
react-progress
ProgressBar		 17.156 kB
6.9 kB
react-provider
FluentProvider		 24.743 kB
8.92 kB
react-radio
Radio		 32.743 kB
10.357 kB
react-radio
RadioGroup		 15.831 kB
6.446 kB
react-select
Select		 27.804 kB
10.14 kB
react-slider
Slider		 38.129 kB
12.803 kB
react-spinbutton
SpinButton		 35.284 kB
11.765 kB
react-spinner
Spinner		 25.317 kB
8.553 kB
react-swatch-picker
@fluentui/react-swatch-picker - package		 106.899 kB
30.866 kB
react-switch
Switch		 35.371 kB
11.336 kB
react-table
DataGrid		 162.071 kB
45.872 kB
react-table
Table (Primitives only)		 42.825 kB
13.882 kB
react-table
Table as DataGrid		 132.323 kB
36.672 kB
react-table
Table (Selection only)		 70.693 kB
20.017 kB
react-table
Table (Sort only)		 69.336 kB
19.63 kB
react-tag-picker
@fluentui/react-tag-picker - package		 188.73 kB
56.597 kB
react-tags
InteractionTag		 15.506 kB
6.232 kB
react-tags
Tag		 30.306 kB
9.905 kB
react-tags
TagGroup		 84.031 kB
24.92 kB
react-teaching-popover
TeachingPopover		 102.747 kB
30.737 kB
react-text
Text - Default		 17.133 kB
6.737 kB
react-text
Text - Wrappers		 20.293 kB
7.063 kB
react-textarea
Textarea		 26.652 kB
9.764 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 35.835 kB
7.512 kB
react-theme
Teams: Light theme		 19.794 kB
5.602 kB
react-timepicker-compat
TimePicker		 110.6 kB
36.56 kB
react-toast
Toast (including Toaster)		 103.062 kB
30.965 kB
react-tooltip
Tooltip		 58.64 kB
20.312 kB
react-tree
FlatTree		 148.801 kB
42.694 kB
react-tree
PersonaFlatTree		 149.559 kB
42.802 kB
react-tree
PersonaTree		 145.818 kB
41.691 kB
react-tree
Tree		 145.066 kB
41.565 kB
react-utilities
SSRProvider		 180 B
160 B
🤖 This report was generated against aba3aae2ca7ebcd53f1cc84893e440a6acf00fcc

@mainframev mainframev force-pushed the chore/ts-update-5-5 branch 2 times, most recently from 0e865c5 to 0a3b8eb Compare December 23, 2024 15:43
@github-actions github-actions bot added the CI label Dec 23, 2024
@mainframev mainframev force-pushed the chore/ts-update-5-5 branch 3 times, most recently from 9f52366 to 415da9a Compare December 23, 2024 22:50
@github-actions github-actions bot removed the CI label Dec 23, 2024
mainframev
mainframev commented Dec 27, 2024
View reviewed changes
@mainframev mainframev marked this pull request as ready for review December 30, 2024 18:05
@mainframev mainframev marked this pull request as draft June 9, 2025 18:11
@mainframev mainframev force-pushed the chore/ts-update-5-5 branch from 61c67aa to 5798c21 Compare June 9, 2025 18:54
@github-actions github-actions bot removed Type: RFC Request for Feedback CI NX: core labels Jun 9, 2025
@mainframev mainframev force-pushed the chore/ts-update-5-5 branch from 5798c21 to 349ee4c Compare June 9, 2025 19:04
github-actions[bot]
github-actions bot reviewed Jun 9, 2025
View reviewed changes
change/@fluentui-api-docs-207b7892-f6fc-403e-9ab3-2d4df19f05ea.json
@@ -0,0 +1,7 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/Positioning 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.chromium.png 779 Changed
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 605 Changed
vr-tests-web-components/Checkbox 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/Checkbox. - Dark Mode.normal.chromium_1.png 3 Changed
vr-tests-web-components/TextInput 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/TextInput. - Dark Mode.normal.chromium_1.png 286 Changed
vr-tests/Pivot - Overflow 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/Pivot - Overflow.Tabs - RTL.chromium.png 4524 Changed
vr-tests/react-charting-AreaChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-AreaChart.Custom Accessibility.default.chromium.png 11 Changed
vr-tests/react-charting-GaugeChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-GaugeChart.Basic.default.chromium.png 2 Changed
vr-tests/react-charting-LineChart 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-LineChart.Multiple - Dark Mode.default.chromium.png 181 Changed
vr-tests/react-charting-LineChart.Multiple.default.chromium.png 192 Changed

github-actions[bot]
github-actions bot reviewed Jun 10, 2025
View reviewed changes
change/@fluentui-api-docs-207b7892-f6fc-403e-9ab3-2d4df19f05ea.json
@@ -0,0 +1,7 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/Positioning 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 859 Changed
vr-tests-react-components/Positioning.Positioning end.chromium.png 324 Changed
vr-tests-react-components/Skeleton converged 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Skeleton converged.Opaque Skeleton with circle - Dark Mode.default.chromium.png 2 Changed
vr-tests-react-components/Skeleton converged.Opaque Skeleton with circle - High Contrast.default.chromium.png 1 Changed
vr-tests-react-components/TagPicker 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png 1321 Changed
vr-tests-web-components/Badge 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png 444 Changed
vr-tests-web-components/Checkbox 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/Checkbox. - Dark Mode.normal.chromium_1.png 3 Changed
vr-tests-web-components/MenuList 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/MenuList. - Dark Mode.normal.chromium.png 500 Changed
vr-tests-web-components/TextInput 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/TextInput. - Dark Mode.normal.chromium_1.png 286 Changed
vr-tests/Callout 7 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/Callout.Bottom center.default.chromium.png 2116 Changed
vr-tests/Callout.Bottom left edge.default.chromium.png 2181 Changed
vr-tests/Callout.Beak 25.default.chromium.png 2185 Changed
vr-tests/Callout.No callout width specified.default.chromium.png 2126 Changed
vr-tests/Callout.Top center.default.chromium.png 2113 Changed
vr-tests/Callout.Right center.default.chromium.png 2080 Changed
vr-tests/Callout.Top left edge.default.chromium.png 2196 Changed
vr-tests/Keytip 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/Keytip.Offset.default.chromium.png 86 Changed
vr-tests/Keytip.Root.default.chromium.png 51 Changed
vr-tests/react-charting-GaugeChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-GaugeChart.Basic.default.chromium.png 2 Changed
vr-tests/react-charting-LineChart 3 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-LineChart.Multiple - Dark Mode.default.chromium.png 181 Changed
vr-tests/react-charting-LineChart.Multiple.default.chromium.png 192 Changed
vr-tests/react-charting-LineChart.Multiple - RTL.default.chromium.png 200 Changed
vr-tests/react-charting-MultiStackBarChart 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-MultiStackBarChart.Basic_Absolute - RTL.default.chromium.png 343 Changed
vr-tests/react-charting-MultiStackBarChart.Basic_Absolute.default.chromium.png 359 Changed
vr-tests/react-charting-VerticalBarChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png 3 Changed

There were 2 duplicate changes discarded. Check the build logs for more information.

@mainframev mainframev force-pushed the chore/ts-update-5-5 branch from 2c2428c to 4aaafd6 Compare June 10, 2025 09:00
github-actions[bot]
github-actions bot reviewed Jun 10, 2025
View reviewed changes
change/@fluentui-api-docs-207b7892-f6fc-403e-9ab3-2d4df19f05ea.json
@@ -0,0 +1,7 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/Avatar Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png 6 Changed
vr-tests-react-components/Positioning 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 971 Changed
vr-tests-react-components/Positioning.Positioning end.chromium.png 581 Changed
vr-tests-react-components/TagPicker 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png 1321 Changed
vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png 635 Changed
vr-tests-web-components/RadioGroup 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/RadioGroup. - Dark Mode.normal.chromium_1.png 59 Changed
vr-tests-web-components/Switch 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/Switch. - Dark Mode.normal.chromium_1.png 92 Changed
vr-tests-web-components/TextInput 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/TextInput. - Dark Mode.normal.chromium_1.png 286 Changed
vr-tests/Coachmark 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/Coachmark.Collapsed.default.chromium.png 159 Changed
vr-tests/Keytip 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/Keytip.Offset.default.chromium.png 86 Changed
vr-tests/react-charting-LineChart 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-LineChart.Multiple.default.chromium.png 192 Changed
vr-tests/react-charting-LineChart.Multiple - Dark Mode.default.chromium.png 181 Changed

There were 3 duplicate changes discarded. Check the build logs for more information.

mainframev and others added 17 commits June 10, 2025 17:32
@mainframev
chore: bump typescript to 5.5.2
f844deb
@mainframev
chore: update generated api files
54b71c8 
chore(utilities): update api.md

chore(react-utilities): update api.md

chore(style-utilities): update api.md
@mainframev
chore(web-components): remove ts suppressions
390e913
@mainframev
chore(react-utilities): remove TS2590 error
d5a4006
@mainframev
chore(merge-styles): fix ts type issue
efcdbab
@mainframev
chore(utilities): fix ts type error after upgrade
85e354b
@mainframev
chore(codemods): fix issues related to ts 5.5 upgrade
daa62b5
@mainframev
chore: update change files
439a4b4
@mainframev
chore: use jsDoc import tag
2a77366
@mainframev
chore(codemods): bump ts-morph to 23.0.0
e0da29b
@mainframev
chore(scripts): remove redundant ts suppression
b34f7a3
@mainframev
chore(merge-styles): inline assertion
4f9a682
@mainframev
chore(codemods): remove ts 5.3
592c5e1
@mainframev
chore: dedupe
8abf35f
@mainframev
chore(wc): update Intl return type causing build to fail
d0c3919
@mainframev
chore: update change files
d5742be
@mainframev
chore: update api.md files
ba16d20
@mainframev mainframev force-pushed the chore/ts-update-5-5 branch from 4aaafd6 to ba16d20 Compare June 10, 2025 15:32
github-actions[bot]
github-actions bot reviewed Jun 10, 2025
View reviewed changes
change/@fluentui-api-docs-207b7892-f6fc-403e-9ab3-2d4df19f05ea.json
@@ -0,0 +1,7 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/Positioning 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.chromium.png 715 Changed
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 189 Changed
vr-tests-react-components/Skeleton converged 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Skeleton converged.Opaque Skeleton with circle - High Contrast.default.chromium.png 1 Changed
vr-tests-react-components/TagPicker 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png 635 Changed
vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png 1321 Changed
vr-tests-web-components/Avatar 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/Avatar. - Dark Mode.normal.chromium.png 10381 Changed
vr-tests-web-components/Badge 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png 444 Changed
vr-tests-web-components/Checkbox 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/Checkbox. - Dark Mode.normal.chromium_1.png 3 Changed
vr-tests-web-components/MenuList 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/MenuList. - Dark Mode.normal.chromium.png 500 Changed
vr-tests-web-components/Switch 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/Switch. - Dark Mode.normal.chromium_1.png 92 Changed
vr-tests-web-components/TextInput 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/TextInput. - Dark Mode.normal.chromium_1.png 286 Changed
vr-tests/Callout 9 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/Callout.Bottom left edge - RTL.default.chromium.png 2186 Changed
vr-tests/Callout.Root.default.chromium.png 2181 Changed
vr-tests/Callout.Bottom right edge - RTL.default.chromium.png 1114 Changed
vr-tests/Callout.Gap space 25.default.chromium.png 2181 Changed
vr-tests/Callout.Bottom right edge.default.chromium.png 1120 Changed
vr-tests/Callout.Right center.default.chromium.png 2080 Changed
vr-tests/Callout.No callout width specified.default.chromium.png 2126 Changed
vr-tests/Callout.Top center.default.chromium.png 2113 Changed
vr-tests/Callout.Top left edge.default.chromium.png 2196 Changed
vr-tests/Coachmark 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/Coachmark.Collapsed.default.chromium.png 159 Changed
vr-tests/Keytip 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/Keytip.Root.default.chromium.png 51 Changed
vr-tests/react-charting-AreaChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-AreaChart.Custom Accessibility.default.chromium.png 11 Changed
vr-tests/react-charting-GaugeChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-GaugeChart.Basic.default.chromium.png 2 Changed
vr-tests/react-charting-LineChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-LineChart.Events.default.chromium.png 1 Changed
vr-tests/react-charting-MultiStackBarChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-MultiStackBarChart.Basic_Absolute.default.chromium.png 359 Changed
vr-tests/react-charting-VerticalBarChart 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png 3 Changed
vr-tests/react-charting-VerticalBarChart.Grouped - Wrap Labels - RTL.default.chromium.png 3263 Changed

There were 6 duplicate changes discarded. Check the build logs for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hotell Hotell Hotell left review comments

@fabricteam fabricteam fabricteam left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@Mitch-At-Work Mitch-At-Work Awaiting requested review from Mitch-At-Work Mitch-At-Work is a code owner

@mltejera mltejera Awaiting requested review from mltejera

@marcosmoura marcosmoura Awaiting requested review from marcosmoura marcosmoura is a code owner

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT GeoffCoxMSFT is a code owner

@chpalac chpalac Awaiting requested review from chpalac chpalac is a code owner

@ling1726 ling1726 Awaiting requested review from ling1726 ling1726 is a code owner

@dmytrokirpa dmytrokirpa Awaiting requested review from dmytrokirpa dmytrokirpa is a code owner

@behowell behowell Awaiting requested review from behowell

@spmonahan spmonahan Awaiting requested review from spmonahan spmonahan is a code owner

@khmakoto khmakoto Awaiting requested review from khmakoto

@dzearing dzearing Awaiting requested review from dzearing dzearing is a code owner

@ThomasMichon ThomasMichon Awaiting requested review from ThomasMichon

@Jahnp Jahnp Awaiting requested review from Jahnp

@sopranopillow sopranopillow Awaiting requested review from sopranopillow

@ValentinaKozlova ValentinaKozlova Awaiting requested review from ValentinaKozlova ValentinaKozlova is a code owner

@ms-acalzaretto ms-acalzaretto Awaiting requested review from ms-acalzaretto

@bigbadcapers bigbadcapers Awaiting requested review from bigbadcapers

@Jacqueline-ms Jacqueline-ms Awaiting requested review from Jacqueline-ms

@JustSlone JustSlone Awaiting requested review from JustSlone

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@tudorpopams tudorpopams Awaiting requested review from tudorpopams

At least 1 approving review is required to merge this pull request.

Assignees

@mainframev mainframev

Labels
Area: Build System Area: Typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mainframev @fabricteam @Hotell