Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(declarative-chart): Create Scatter plot #33843

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

feat(declarative-chart): Create Scatter plot #33843

wants to merge 13 commits into from

Conversation

Anush2303
Copy link
Contributor

@Anush2303 Anush2303 commented Feb 14, 2025 •
edited
Loading

New Behavior

Created Scatter plot from points in line chart.
image

Related Issue(s)

  • Fixes #

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

📊 Bundle size report

✅ No changes found

@github-actions GitHub Actions
Copy link

Pull request demo site: URL

@Anush2303 Anush2303 marked this pull request as ready for review February 17, 2025 06:37
@Anush2303 Anush2303 requested a review from a team as a code owner February 17, 2025 06:37
@AtishayMsft
Copy link
Contributor

AtishayMsft commented Feb 19, 2025 •
edited
Loading

export function domainRangeOfNumericForAreaChart(

define an additional argument called padding to utility functions. And move the marker size logic to line chart only

Refers to: packages/charts/react-charting/src/utilities/utilities.ts:906 in a739a12. [](commit_id = a739a12, deletion_comment = False)

@AtishayMsft
Copy link
Contributor

can you share result of running playwright workflow for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@AtishayMsft AtishayMsft AtishayMsft left review comments

@krkshitij krkshitij krkshitij left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Anush2303 @AtishayMsft @fabricteam @krkshitij