Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(declarative-chart): Create Scatter plot #33843

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Prev Previous commit
Next Next commit
take absolute value of maximum pixel size
  • Loading branch information
Anush2303 committed Feb 15, 2025
commit 1a0ac1c719af8e3b92eeb1701d397e39f586d960
7 changes: 5 additions & 2 deletions packages/charts/react-charting/src/utilities/utilities.ts
Original file line number Diff line number Diff line change
@@ -447,7 +447,10 @@ export function createNumericYAxis(
? 0
: yMinValue!;
const maxMarkerSizeInPixelsForYAxis = maxMarkerSize
? (maxMarkerSize * (finalYmin - finalYmax)) / (margins.top! - containerHeight + margins.bottom! + 2 * maxMarkerSize)
? Math.abs(
(maxMarkerSize * (finalYmin - finalYmax)) /
(margins.top! - containerHeight + margins.bottom! + 2 * maxMarkerSize),
)
: 0;
const domainValues = prepareDatapoints(
finalYmax + maxMarkerSizeInPixelsForYAxis,
@@ -922,7 +925,7 @@ export function domainRangeOfNumericForAreaChart(
});
})!;
const maxMarkerSizeInPixelsForXAxis = maxMarkerSize
? (maxMarkerSize * (xMax - xMin)) / (width - margins.right! - margins.left! - 2 * maxMarkerSize)
? Math.abs((maxMarkerSize * (xMax - xMin)) / (width - margins.right! - margins.left! - 2 * maxMarkerSize))
: 0;
const rStartValue = margins.left!;
const rEndValue = width - margins.right!;
Loading
Oops, something went wrong.