Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(declarative-chart): Create Scatter plot #33843

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Prev Previous commit
Next Next commit
change prop name
  • Loading branch information
Anush2303 committed Feb 19, 2025
commit 5df5ebb9b724d418dd7dc36e3e5f119a2400fee3
2 changes: 1 addition & 1 deletion packages/charts/react-charting/etc/react-charting.api.md
Original file line number Diff line number Diff line change
@@ -1012,11 +1012,11 @@ export interface ILineChartProps extends ICartesianChartProps {
enablePerfOptimization?: boolean;
eventAnnotationProps?: IEventsAnnotationProps;
getCalloutDescriptionMessage?: (calloutDataProps: ICustomizedCalloutData) => string | undefined;
lineMode?: 'default' | 'scatter';
onRenderCalloutPerDataPoint?: IRenderFunction<ICustomizedCalloutData>;
onRenderCalloutPerStack?: IRenderFunction<ICustomizedCalloutData>;
// (undocumented)
optimizeLargeData?: boolean;
scatterMarkersMode?: boolean;
styles?: IStyleFunctionOrObject<ILineChartStyleProps, ILineChartStyles>;
}

Original file line number Diff line number Diff line change
@@ -239,7 +239,7 @@ export const DeclarativeChart: React.FunctionComponent<DeclarativeChartProps> =
if (isAreaChart) {
return <AreaChart {...chartProps} />;
}
return <LineChart {...chartProps} mode={isScatterMarkers ? 'scatter' : 'default'} />;
return <LineChart {...chartProps} lineMode={isScatterMarkers ? 'scatter' : 'default'} />;
};
return checkAndRenderChart(renderChartJsx, isAreaChart);
case 'heatmap':
Loading
Oops, something went wrong.
Loading
Oops, something went wrong.