Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix web-components lint setup to avoid leaking rules to json parser scope #33852

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: resolve consuming invalid root config by vscode lint server to…
… resolve json parsing issues
  • Loading branch information
Hotell committed Feb 19, 2025
commit 82c3e8612af1c60c7731cff99b398e7773bb7f13
15 changes: 8 additions & 7 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
// Default eslintrc for packages without one, or files outside a package
// NOTE:
// - this is very old config (v8/v0 active era) - we don't use it anywhere
// - if nx migration adds any kind of overrides undo these changes as our config setup is not compatible with extending package from root
// TODO:
// - this needs to be re-done when doing whole lint re-structuring within monorepo
// - will be used to follow standard NX linting approach
{
"root": true,
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 2018,
@@ -19,12 +27,5 @@
"**/node_modules",
"**/temp",
"**/*.scss.ts"
],
"overrides": [
{
"files": "*.json",
"parser": "jsonc-eslint-parser",
"rules": {}
}
]
}
7 changes: 0 additions & 7 deletions tools/workspace-plugin/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -12,13 +12,6 @@
]
},
"overrides": [
{
"files": "*.json",
"parser": "jsonc-eslint-parser",
"rules": {
"@typescript-eslint/naming-convention": "off"
}
},
{
"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
"rules": {}