Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vr-tests-react-components): migrate to new StoryWright api to define Steps to resolve VR snapshoting issues #33860

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+371 −359
Open

fix(vr-tests-react-components): migrate to new StoryWright api to define Steps to resolve VR snapshoting issues #33860

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aca3543
fix(vr-tests-react-components): migrate to new StoryWright api to def…
Hotell Feb 18, 2025
7123adb
chore(vr-tests-react-components): fail CI if we have invalid VR test …
Hotell Feb 18, 2025
522c1f5
feat(vr-tests-rc): support both CSF2 and CSF3 for story variant creation
Hotell Feb 20, 2025
15438b9
chore: migrate to storywrigt storybook7.12 that ships required features
Hotell Feb 27, 2025
94202ca
fix(vr-tests-react-components): add proper type return annotation to …
Hotell Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(vr-tests-react-components): fail CI if we have invalid VR test … 
…stories
  • Loading branch information
@Hotell
Hotell committed Feb 27, 2025
commit 7123adb89c64d19e6c313d9ac935ed401e4e61cf
2 changes: 1 addition & 1 deletion apps/vr-tests-react-components/package.json
View file
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@
"start": "storybook dev",
"test": "just-scripts test",
"type-check": "tsc -p . --noEmit --baseUrl .",
"test-vr": "storywright --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true"
"test-vr": "storywright --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true --bailOnStoriesError"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new functionality that we shipped to SW, now if there will be any issues within our VR tests pipeline will fail ! 💪

},
"devDependencies": {
"@fluentui/eslint-plugin": "*",