fix(react-color-picker): place thumb outside of Sliders and ColorArea #33880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
🤖 This report was generated against a218a5dc65fafa2e5b18a8ec8258d08b0da4dcbf |
|
Pull request demo site: URL |
fabricteam
reviewed
Feb 21, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
ColorPicker Converged 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| ColorPicker Converged.shape.default.chromium.png | 10446 | Changed |
| ColorPicker Converged.Default.default.chromium.png | 2960 | Changed |
| ColorPicker Converged.Alpha Sliders.default.chromium.png | 66 | Changed |
| ColorPicker Converged.Default - RTL.default.chromium.png | 2961 | Changed |
| ColorPicker Converged.Default - Dark Mode.default.chromium.png | 13634 | Changed |
| ColorPicker Converged.Default - High Contrast.default.chromium.png | 17524 | Changed |
Drawer 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.overlay drawer full - Dark Mode.chromium.png | 991 | Changed |
ValentinaKozlova
force-pushed
the
fix/color-picker-thumb
branch
from
a07f6d5 to
6661b37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for thumb positioning looks weird on edges:
Talked to @gouttierre and Toshie, we decided to stay with this design which is currently in V8.
Previous Behavior
New Behavior