docs: update positioning examples to work with page resize #33904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
Hotell
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The cover & shorthand examples on the positioning docs page were clipped when the page zoomed/resized down at all:
While this could theoretically be solved by just adding a scroll overflow without changing the layout at all, the issue is that the current layout doesn't even fit within storybook at full size. So adding a scroll overflow style makes it scroll-overflow all the time, looking rather odd:
(the left margin of the story is necessary to ensure the popup has enough space to render at smaller sizes)
New Behavior
I updated the grid layout to be a more compact grid so it would fit within the story at full width, and also be able to scroll-overflow at smaller screens:
Related Issue(s)