Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary props #33906

Draft
wants to merge 3 commits into
base: usr/agupta/stable-V9
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove deprecated props
  • Loading branch information
krkshitij committed Feb 24, 2025
commit 1e5a3d52529d68874e7e125eadf80d35f435bef2
Original file line number Diff line number Diff line change
@@ -69,8 +69,6 @@ export const CartesianChart: React_2.FunctionComponent<ModifiedCartesianChartPro
// @public
export interface CartesianChartProps {
calloutProps?: Partial<ChartPopoverProps>;
// @deprecated
chartLabel?: string;
className?: string;
customDateTimeFormatter?: (dateTime: Date) => string;
customProps?: (dataPointCalloutProps: any) => ChartPopoverProps;
@@ -857,12 +855,6 @@ export interface VerticalBarChartStyleProps extends CartesianChartStyleProps {
// @public
export interface VerticalBarChartStyles extends CartesianChartStyles {
barLabel: string;
// @deprecated
xAxisTicks?: string;
// @deprecated
yAxisDomain?: string;
// @deprecated
yAxisTicks?: string;
}

// @public (undocumented)
Original file line number Diff line number Diff line change
@@ -303,12 +303,6 @@ export interface CartesianChartProps {
*/
href?: string;

/**
* Label to apply to the whole chart.
* @deprecated - Use your chart label for the chart.
*/
chartLabel?: string;

// eslint-disable-next-line @typescript-eslint/no-explicit-any
legendsOverflowText?: any;

Original file line number Diff line number Diff line change
@@ -122,24 +122,6 @@ export interface VerticalBarChartStyleProps extends CartesianChartStyleProps {
* {@docCategory VerticalBarChart}
*/
export interface VerticalBarChartStyles extends CartesianChartStyles {
/**
* Style for the lines representing the ticks along the x-axis.
* @deprecated This style cannot be customized anymore
*/
xAxisTicks?: string;

/**
* Style for the line representing the domain of the y-axis.
* @deprecated This style cannot be customized anymore
*/
yAxisDomain?: string;

/**
* Style for the lines representing the ticks along the y-axis.
* @deprecated This style cannot be customized anymore
*/
yAxisTicks?: string;

/**
* Style for the bar labels
*/
Original file line number Diff line number Diff line change
@@ -5,9 +5,6 @@ import { tokens, typographyStyles } from '@fluentui/react-theme';

export const verticalbarchartClassNames: SlotClassNames<VerticalBarChartStyles> = {
opacityChangeOnHover: 'fui-vbc__opacityChangeOnHover',
xAxisTicks: 'fui-vbc__xAxisTicks',
yAxisTicks: 'fui-vbc__yAxisTicks',
yAxisDomain: 'fui-vbc__yAxisDomain',
tooltip: 'fui-vbc__tooltip',
barLabel: 'fui-vbc__barLabel',
root: '',
@@ -32,13 +29,6 @@ export const verticalbarchartClassNames: SlotClassNames<VerticalBarChartStyles>
};
const useStyles = makeStyles({
opacityChangeOnHover: {},
xAxisTicks: {},
yAxisTicks: {
transform: 'scaleX(-1)',
},
yAxisDomain: {
transform: 'scaleX(-1)',
},
tooltip: {
...typographyStyles.body1,
display: 'flex',
@@ -68,9 +58,6 @@ export const useVerticalBarChartStyles_unstable = (props: VerticalBarChartProps)
verticalbarchartClassNames.opacityChangeOnHover,
baseStyles.opacityChangeOnHover /*props.styles?.opacityChangeOnHover*/,
),
xAxisTicks: mergeClasses(baseStyles.xAxisTicks /*props.styles?.xAxisTicks*/),
yAxisTicks: mergeClasses(baseStyles.yAxisTicks /*props.styles?.yAxisTicks*/),
yAxisDomain: mergeClasses(baseStyles.yAxisDomain /*props.styles?.yAxisDomain*/),
tooltip: mergeClasses(verticalbarchartClassNames.tooltip, baseStyles.tooltip /*props.styles?.tooltip*/),
barLabel: mergeClasses(verticalbarchartClassNames.barLabel, baseStyles.barLabel /*props.styles?.barLabel*/),
};