feat(react-charts-preview): Migrate VSBC to V9 #33909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
srmukher
reviewed
Feb 26, 2025
|
Pull request demo site: URL |
srmukher
reviewed
Feb 26, 2025
...arts-preview/library/src/components/VerticalStackedBarChart/VerticalStackedBarChart.types.ts
Show resolved
Hide resolved
🕵 fluentuiv9 No visual regressions between this PR and main |
AtishayMsft
reviewed
Feb 28, 2025
...ct-charts-preview/library/src/components/VerticalStackedBarChart/VerticalStackedBarChart.tsx
Show resolved
Hide resolved
AtishayMsft
reviewed
Feb 28, 2025
...ct-charts-preview/library/src/components/VerticalStackedBarChart/VerticalStackedBarChart.tsx
Show resolved
Hide resolved
AtishayMsft
reviewed
Feb 28, 2025
| _points = props.data || []; | ||
| _barWidth = getBarWidth(props.barWidth, props.maxBarWidth); | ||
| const defaultColors: string[] = [ | ||
| tokens.colorPaletteBlueForeground2, |
There was a problem hiding this comment.
You mean, we should use new set of default colors?
AtishayMsft
reviewed
Feb 28, 2025
...ct-charts-preview/library/src/components/VerticalStackedBarChart/VerticalStackedBarChart.tsx
Show resolved
Hide resolved
AtishayMsft
reviewed
Feb 28, 2025
...ct-charts-preview/library/src/components/VerticalStackedBarChart/VerticalStackedBarChart.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Feb 28, 2025
| import { max as d3Max, min as d3Min } from 'd3-array'; | ||
| import { Axis as D3Axis } from 'd3-axis'; | ||
| import { select as d3Select } from 'd3-selection'; | ||
| import { useVerticalStackedBarChartStyles_unstable } from './useVerticalStackedBarChartStyles.styles'; |
There was a problem hiding this comment.
Just added tabIndex attribute. Just like other v9 charts.
AtishayMsft
reviewed
Feb 28, 2025
...arts-preview/library/src/components/VerticalStackedBarChart/VerticalStackedBarChart.types.ts
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Feb 28, 2025
.../charts/react-charts-preview/library/src/components/CommonComponents/CartesianChart.types.ts
Show resolved
Hide resolved
AtishayMsft
reviewed
Feb 28, 2025
.../charts/react-charts-preview/library/src/components/CommonComponents/CartesianChart.types.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)