fix(react tabs): Selected tab is not visible in HC on Windows #33910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
fabricteam
reviewed
Feb 26, 2025
packages/react-components/react-tabs/library/src/components/Tab/useTabStyles.styles.ts
Show resolved
Hide resolved
ValentinaKozlova
force-pushed
the
fix/react-tabs-selected-hc
branch
from
1944098 to
bba4b9b
Compare
ValentinaKozlova
requested review from
dmytrokirpa and
a team
as code owners
packages/react-components/react-tabs/library/src/components/Tab/useTabStyles.styles.ts
Outdated
Show resolved
Hide resolved
dmytrokirpa
approved these changes
Feb 26, 2025
ValentinaKozlova
force-pushed
the
fix/react-tabs-selected-hc
branch
from
dd5909c to
9ef4272
Compare
ValentinaKozlova
force-pushed
the
fix/react-tabs-selected-hc
branch
from
9ef4272 to
44764f3
Compare
smhigley
reviewed
Feb 26, 2025
packages/react-components/react-tabs/library/src/components/Tab/useTabStyles.styles.ts
Show resolved
Hide resolved
packages/react-components/react-tabs/library/src/components/Tab/useTabStyles.styles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-tabs/library/src/components/Tab/useTabStyles.styles.ts
Outdated
Show resolved
Hide resolved
smhigley
approved these changes
Feb 26, 2025
smhigley
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the bug in ADO:
When using subtle-circular/filled-circular appearance in high contrast aquatic or dessert theme, it is hard to differentiate what tab is selected in the tablist.
This is mostly due to having no background color for selected tab in these theme.
disabledstatefilled-circularon hover doesn't change background color:Related Issue(s)
ADO issue 24802