Card component custom style hook unstable #33912
Draft
+244
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request demo site: URL |
mltejera
reviewed
Feb 26, 2025
packages/react-components/react-card/library/src/components/CustomHooks/index.ts
Outdated
Show resolved
Hide resolved
…ithub.com/terynk/fluentui into card-component-custom-style-hook-unstable
packages/react-components/react-card/library/src/components/CardFooter/CardFooter.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Owen Campbell <ocampbell95@gmail.com>
📊 Bundle size report
Unchanged fixtures
|
mltejera
reviewed
Feb 28, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "minor", | |||
| "comment": "fix custom style hook for Card, CardFooter, CardHeader, CardPreview", | |||
There was a problem hiding this comment.
double check this format matches the previous change logs.
mltejera
reviewed
Feb 28, 2025
|
|
||
| const useCardStyle = makeStyles({ | ||
| root: { | ||
| backgroundColor: tokens.colorNeutralBackground3, |
There was a problem hiding this comment.
simplify these styles - just set than background to 'red' to ensure the styles pump through.
Then make it clear in the PR description that we'll remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old Behavior
Users were unable to apply Custom Style Hooks to Card, CardHeader, CardFooter, and CardPreview.
New Behavior
Users can now apply Custom Style Hooks to Card, CardHeader, CardFooter, and CardPreview. The screen shots below show test cases for each component that demonstrate the ability to apply Custom Hooks. In each Custom Hook, the backgroundColor of the component was updated to tokens.colorNeutralBackground3. The test code will be removed but can be found in commits 03817b9 and 65d20ca. The test code applies Custom Style Hooks to the Default styling of each component.
Test Screenshots
Default styling can be found under each subpage on the Fluent V9 Website
Card
CardFooter
CardHeader
CardPreview
