-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix: Implement Custom Style Hook for Card component #33912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
khmakoto
merged 18 commits into
microsoft:master
from
terynk:card-component-custom-style-hook-unstable
Mar 6, 2025
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
fe81a61
added custom style hooks for Card components
terynkum 65d20ca
Story for Card Custom Styles
terynkum 1f4f6bb
ran yarn change
terynkum 14d4859
Merge branch 'master' into card-component-custom-style-hook-unstable
terynk 482511d
Merge branch 'card-component-custom-style-hook-unstable' of https://g…
terynkum 92816d3
consolidated index.ts into useCardStyles for simplicity
terynkum 305add7
updated import statement for Card story
terynkum a87d46c
consolidated useCardStyles into CardDefault story
terynkum 494c079
updated shared-contexts dependencies
terynkum 8e91eec
Updated import statement for CardFooter
terynk 1c4a0ab
Disabled eslint rule for unstable suffix
terynkum 72b72a8
removed multiple exports
terynkum 03817b9
Added custom styling to Footer, Header, and Preview
terynkum 4a67bb5
simplified styles only changed background to red
terynkum ca5aa13
updated change file to match previous file format
terynkum 35eb165
Merge branch 'microsoft:master' into card-component-custom-style-hook…
terynk a5dc632
removed StoryBook examples, custom styling remains
terynkum d43fe6b
Merge branch 'card-component-custom-style-hook-unstable' of https://g…
terynkum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-card-7fc24491-6b02-436b-8f94-650824f19639.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "minor", | ||
"comment": "fix: implemented custom style hook for Card, CardFooter, CardHeader, CardPreview", | ||
"packageName": "@fluentui/react-card", | ||
"email": "terynkum@microsoft.com", | ||
"dependentChangeType": "patch" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 10 additions & 2 deletions
12
packages/react-components/react-card/stories/src/Card/CardDefault.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.