fix: incorrect tokens used across multiple input components #33927
+31
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tates fix(react-dropdown): use correct tokens for hover, active and focus states
mainframev
added
Component: Dropdown
Component: Combobox
Component: TagPicker
Component: Textarea
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
fabricteam
reviewed
Feb 28, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Combobox Converged 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Combobox Converged.Invalid- outline.focused.chromium.png | 24 | Changed |
| Combobox Converged.Size- small.focused.chromium.png | 22 | Changed |
| Combobox Converged.Appearance- outline (default).focused.chromium.png | 24 | Changed |
| Combobox Converged.With value.focused.chromium.png | 24 | Changed |
| Combobox Converged.Size- large.focused.chromium.png | 26 | Changed |
| Combobox Converged.With placeholder.focused.chromium.png | 24 | Changed |
Dialog 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Dialog.Integration Combobox Inline.chromium.png | 36 | Changed |
Drawer 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.overlay drawer full.chromium.png | 3285 | Changed |
TagPicker 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| TagPicker.expand icon - High Contrast.chromium.png | 129 | Changed |
| TagPicker.expand icon - Dark Mode.chromium.png | 25 | Changed |
| TagPicker.secondary action - Dark Mode.chromium.png | 25 | Changed |
| TagPicker.secondary action - High Contrast.chromium.png | 129 | Changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing reported issue (#33135), we have visual inconsistencies between Figma designs and our multiple input components. Those components currently do not have shared styles, so it has to be fixed on multiple places. The reported issue mention high-contrast, but it happens in all themes for outline appearance for hover, active and focus styles. Combobox & Dropdown, Textarea, TimePickerCompat (fixed by fixing combobox styles), TagPicker.
Previous Behavior
hover in high contrast:
focus in high contrast:
figma spec:
New Behavior
Updated to visually match design spec
Related Issue(s)