Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect tokens used across multiple input components #33927

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+31 −11
Open

fix: incorrect tokens used across multiple input components #33927

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c1e823
fix(react-textarea): use correct token for focus
mainframev Feb 28, 2025
9c62689
chore: update change files
mainframev Feb 28, 2025
ef0cad7
fix(react-combobox): use correct tokens for hover, active and focus s…
mainframev Feb 28, 2025
131b71e
fix(react-tag-picker): use correct tokens for hover, active and focus…
mainframev Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update change files
  • Loading branch information
@mainframev
mainframev committed Feb 28, 2025
commit 9c6268934121a4b32c6b82dfc81433068e222ddc
7 changes: 7 additions & 0 deletions change/@fluentui-react-combobox-106e472a-1ade-4d1f-bc51-5eddd30b8ecf.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Combobox Converged 6 screenshots
Image Name Diff(in Pixels) Image Type
Combobox Converged.Invalid- outline.focused.chromium.png 24 Changed
Combobox Converged.Size- small.focused.chromium.png 22 Changed
Combobox Converged.Appearance- outline (default).focused.chromium.png 24 Changed
Combobox Converged.With value.focused.chromium.png 24 Changed
Combobox Converged.Size- large.focused.chromium.png 26 Changed
Combobox Converged.With placeholder.focused.chromium.png 24 Changed
Dialog 1 screenshots
Image Name Diff(in Pixels) Image Type
Dialog.Integration Combobox Inline.chromium.png 36 Changed
Drawer 1 screenshots
Image Name Diff(in Pixels) Image Type
Drawer.overlay drawer full.chromium.png 3285 Changed
TagPicker 4 screenshots
Image Name Diff(in Pixels) Image Type
TagPicker.expand icon - High Contrast.chromium.png 129 Changed
TagPicker.expand icon - Dark Mode.chromium.png 25 Changed
TagPicker.secondary action - Dark Mode.chromium.png 25 Changed
TagPicker.secondary action - High Contrast.chromium.png 129 Changed

"type": "patch",
"comment": "fix: use correct tokens for hover, active and focus states",
"packageName": "@fluentui/react-combobox",
"email": "vgenaev@gmail.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-tag-picker-ea411c94-0c82-44e5-87ff-5d073f48599d.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: use correct tokens for hover, active and focus states",
"packageName": "@fluentui/react-tag-picker",
"email": "vgenaev@gmail.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-textarea-6305fa37-552a-4cf8-8dd6-92f2dbee276c.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: use correct tokens for hover, active and focus states",
"packageName": "@fluentui/react-textarea",
"email": "vgenaev@gmail.com",
"dependentChangeType": "patch"
}