Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic-Tokens: Generate from token JSON export #33931

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

Mitch-At-Work
Copy link
Contributor

@Mitch-At-Work Mitch-At-Work commented Feb 28, 2025

** DO NOT MERGE ** DRAFT ONLY

Previous Behavior

Tokens were manually implemented (to check architecture) in previous PR

New Behavior

Tokens generated via script to ensure alignment

ToDo:

  • Resolve JSON issues (inline emojies/NULL references)
  • Handle dynamic imports (generic for now)
  • Add fluent 2 mapping on top, to ensure fallbacks are aligned with existing component usage

Copy link

Pull request demo site: URL

@@ -272,6 +272,7 @@ packages/react-components/react-virtualizer/stories @microsoft/xc-uxe @Mitch-At-
packages/react-components/react-skeleton/library @microsoft/cxe-prg
Copy link
Collaborator

@fabricteam fabricteam Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentui-web-components-v3 Visual Regression Report

MenuList 1 screenshots
Image Name Diff(in Pixels) Image Type
MenuList. - RTL.normal.chromium_1.png 39102 Changed
Switch 2 screenshots
Image Name Diff(in Pixels) Image Type
Switch. - Dark Mode.hover.chromium_2.png 92 Changed
Switch. - Dark Mode.normal.chromium_1.png 92 Changed
TextInput 1 screenshots
Image Name Diff(in Pixels) Image Type
TextInput. - Dark Mode.normal.chromium_1.png 288 Changed

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 28, 2025

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 3, 2025

🕵 fluentuiv9 No visual regressions between this PR and main

@@ -272,6 +272,7 @@ packages/react-components/react-virtualizer/stories @microsoft/xc-uxe @Mitch-At-
packages/react-components/react-skeleton/library @microsoft/cxe-prg
Copy link
Collaborator

@fabricteam fabricteam Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv8 Visual Regression Report

react-charting-VerticalBarChart 1 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png 4 Changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants