Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic-Tokens: Generate from token JSON export #33931

Draft
wants to merge 37 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
7a48bb0
Stash initial for now
Mitch-At-Work Feb 11, 2025
13424bc
Add initial Link tokens as example
Mitch-At-Work Feb 12, 2025
5badbf8
Add tsconfig for semantic-tokens
Mitch-At-Work Feb 12, 2025
36cc985
Update indexing and add token vars as exports
Mitch-At-Work Feb 14, 2025
88cc6f4
Change files
Mitch-At-Work Feb 18, 2025
6b008bd
Fix version of react-tokens
Mitch-At-Work Feb 18, 2025
8dba624
Update and connect local build artifacts
Mitch-At-Work Feb 18, 2025
4a8db31
Lint and fix exports
Mitch-At-Work Feb 19, 2025
e2aa7f2
Update E2E for semantic tokens to a dummy test (for now)
Mitch-At-Work Feb 20, 2025
96ef49f
Fix up extra bracket and brand ref color
Mitch-At-Work Feb 20, 2025
1d6d672
remove console
Mitch-At-Work Feb 21, 2025
f478839
Alphebetize order
Mitch-At-Work Feb 24, 2025
bb81096
Update tokens so far
Mitch-At-Work Feb 28, 2025
940f605
Add script to generate
Mitch-At-Work Feb 28, 2025
44bfcdf
Initial script gen
Mitch-At-Work Feb 28, 2025
57c7867
Update tokens and script
Mitch-At-Work Feb 28, 2025
81f1e05
Update script to handle duplicated tokens
Mitch-At-Work Feb 28, 2025
6035592
Add strokeWidthThin fallback
Mitch-At-Work Feb 28, 2025
83f6a0a
Set variable path correctly
Mitch-At-Work Mar 1, 2025
e5671d7
Update latest
Mitch-At-Work Mar 3, 2025
0ed592f
Update with better fallback logic
Mitch-At-Work Mar 3, 2025
c81c862
Update script to handle fallbacks and f2 tokens better
Mitch-At-Work Mar 3, 2025
4d4bd3f
Update naming to handle brackets and spacings
Mitch-At-Work Mar 3, 2025
4609e99
Ensure fallbacks work correctly for FST
Mitch-At-Work Mar 3, 2025
9c3a7fe
Simplify script to match design and add custom fluent fallback map
Mitch-At-Work Mar 5, 2025
032d3b7
Add missing imports structure
Mitch-At-Work Mar 5, 2025
a750369
Fix imports
Mitch-At-Work Mar 5, 2025
a55568e
Update script to add exports
Mitch-At-Work Mar 5, 2025
5658e2d
Update script to handle imports/exports
Mitch-At-Work Mar 5, 2025
56e1102
Token script fixed
Mitch-At-Work Mar 5, 2025
e3a0bba
Update tokens and script
Mitch-At-Work Mar 6, 2025
58bac11
Fix token reference fallback
Mitch-At-Work Mar 6, 2025
791a838
Update api
Mitch-At-Work Mar 6, 2025
9c1c981
Fix port
Mitch-At-Work Mar 6, 2025
8884ea1
Lint all files
Mitch-At-Work Mar 6, 2025
a5bb059
Update and remove eslint rule
Mitch-At-Work Mar 6, 2025
c4719f4
Fix up the ESLint rule
Mitch-At-Work Mar 6, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update and connect local build artifacts
  • Loading branch information
Mitch-At-Work committed Feb 24, 2025
commit 8dba6248937b3683d40ab4cf739d13a23851477a
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -272,6 +272,7 @@ packages/react-components/react-virtualizer/stories @microsoft/xc-uxe @Mitch-At-
packages/react-components/react-skeleton/library @microsoft/cxe-prg
Copy link
Collaborator

@fabricteam fabricteam Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentui-web-components-v3 Visual Regression Report

Accordion 1 screenshots
Image Name Diff(in Pixels) Image Type
Accordion. - Dark Mode.normal.chromium_1.png 2660 Changed
Badge 1 screenshots
Image Name Diff(in Pixels) Image Type
Badge. - Dark Mode.normal.chromium.png 511 Changed

Copy link
Collaborator

@fabricteam fabricteam Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv8 Visual Regression Report

Callout 1 screenshots
Image Name Diff(in Pixels) Image Type
Callout.No callout width specified.default.chromium.png 2319 Changed
react-charting-AreaChart 1 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-AreaChart.Custom Accessibility.default.chromium.png 11 Changed
react-charting-LineChart 1 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-LineChart.Gaps.default.chromium.png 1 Changed
react-charting-VerticalBarChart 1 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png 4 Changed

packages/react-components/react-skeleton/stories @microsoft/cxe-prg
packages/tokens @microsoft/teams-prg
packages/semantic-tokens @microsoft/xc-uxe
packages/react-components/react-tags/library @microsoft/cxe-prg @microsoft/teams-prg
packages/react-components/react-tags/stories @microsoft/cxe-prg @microsoft/teams-prg
packages/react-components/react-migration-v0-v9/library @microsoft/teams-prg
1 change: 1 addition & 0 deletions nx.json
Original file line number Diff line number Diff line change
@@ -151,6 +151,7 @@
"scripts/**/*",
"packages/eslint-plugin/**",
"packages/tokens/**",
"packages/semantic-tokens/**",
"packages/react-conformance/**",
"packages/react-components/**/*"
]
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@
"@fluentui/react-shared-contexts": "^9.21.2",
"@fluentui/react-tabster": "^9.24.0",
"@fluentui/react-theme": "^9.1.24",
"@fluentui/semantic-tokens": "^0.0.0-alpha.1",
"@fluentui/semantic-tokens": "0.0.0-alpha.1",
"@fluentui/react-utilities": "^9.18.20",
"@griffel/react": "^1.5.22",
"@swc/helpers": "^0.5.1"
84 changes: 84 additions & 0 deletions packages/semantic-tokens/etc/semantic-tokens.api.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
## API Report File for "@fluentui/semantic-tokens"

> Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).

```ts

// @public (undocumented)
export const ctrlFocusOuterStroke: string;

// @public (undocumented)
export const ctrlLinkForegroundBrandHover: string;

// @public (undocumented)
export const ctrlLinkForegroundBrandHoverRaw = "--ctrl-link-foreground-brand-hover";

// @public (undocumented)
export const ctrlLinkForegroundBrandPressed: string;

// @public (undocumented)
export const ctrlLinkForegroundBrandPressedRaw = "--ctrl-link-foreground-brand-pressed";

// @public (undocumented)
export const ctrlLinkForegroundBrandRest: string;

// @public (undocumented)
export const ctrlLinkForegroundBrandRestRaw = "--ctrl-link-foreground-brand-rest";

// @public (undocumented)
export const ctrlLinkForegroundNeutralHover: string;

// @public (undocumented)
export const ctrlLinkForegroundNeutralHoverRaw = "--ctrl-link-foreground-neutral-hover";

// @public (undocumented)
export const ctrlLinkForegroundNeutralPressed: string;

// @public (undocumented)
export const ctrlLinkForegroundNeutralPressedRaw = "--ctrl-link-foreground-neutral-pressed";

// @public (undocumented)
export const ctrlLinkForegroundNeutralRest: string;

// @public (undocumented)
export const ctrlLinkForegroundNeutralRestRaw = "--ctrl-link-foreground-neutral-rest";

// @public (undocumented)
export const foregroundCtrlBrandHover = "--foreground-ctrl-brand-hover";

// @public (undocumented)
export const foregroundCtrlBrandPressed = "--foreground-ctrl-brand-pressed";

// @public (undocumented)
export const foregroundCtrlBrandRest = "--foreground-ctrl-brand-rest";

// @public (undocumented)
export const foregroundCtrlNeutralPrimaryDisabled: string;

// @public (undocumented)
export const foregroundCtrlNeutralPrimaryHover = "--foreground-ctrl-neutral-primary-hover";

// @public (undocumented)
export const foregroundCtrlNeutralPrimaryPressed = "--foreground-ctrl-neutral-primary-pressed";

// @public (undocumented)
export const foregroundCtrlNeutralPrimaryRest = "--foreground-ctrl-neutral-primary-rest";

// @public (undocumented)
export const foregroundCtrlOntransparentDisabled: string;

// @public (undocumented)
export const strokewidthDefault: string;

// @public (undocumented)
export const textGlobalBody3Fontsize: string;

// @public (undocumented)
export const textStyleDefaultRegularFontfamily: string;

// @public (undocumented)
export const textStyleDefaultRegularWeight: string;

// (No @packageDocumentation comment for this package)

```