-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility bug fixes: BUG 9826423, BUG 9830293 #33933
Open
v-baambati
wants to merge
6
commits into
microsoft:master
Choose a base branch
from
v-baambati:A11yFixes_2025
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+152
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
v-baambati
commented
Mar 3, 2025
•
edited
Loading
edited
- BUG 9826423 Updated color codes to fix color contrast issue in the stacked bar chart dynamic example.
- BUG 9830293 Updated color codes to fix color contrast issue in legends overflow example.
📊 Bundle size report✅ No changes found |
Pull request demo site: URL |
AtishayMsft
reviewed
Mar 3, 2025
@@ -42,7 +42,7 @@ export class StackedBarChartDynamicExample extends React.Component<{}, IExampleS | |||
getColorFromToken(DataVizPalette.color6), | |||
DefaultPalette.tealDark, | |||
DefaultPalette.teal, | |||
DefaultPalette.tealLight, | |||
getColorFromToken(DataVizPalette.color1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change all the colors to data viz palette.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.