Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPDK: install path fixes for meson and Ubuntu 24.04 #3598

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
OS SUSE uninstall: use assert_that
  • Loading branch information
mcgov committed Feb 5, 2025
commit 3cfa460b979aa339104e9965421679c6174610c7
14 changes: 6 additions & 8 deletions lisa/operating_system.py
Original file line number Diff line number Diff line change
@@ -2129,14 +2129,12 @@ def _uninstall_packages(
install_result = self._node.execute(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install_result -> uninstall_result

command, shell=True, sudo=True, timeout=timeout
)

if install_result.exit_code == 0:
self._log.debug(f"{packages} is/are removed successfully.")
else:
raise LisaException(
f"Failed to remove {packages}. exit_code: {install_result.exit_code}, "
f"stderr: {install_result.stderr}"
)
assert_that(install_result.exit_code).described_as(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install_result.assert_exist_code implemented the similar error message, please reuse it.

f"Failed to remove {packages}. "
f"exit_code: {install_result.exit_code}, "
f"stderr: {install_result.stderr}"
).is_equal_to(0)
self._log.debug(f"{packages} is/are removed successfully.")

def _install_packages(
self,