[Review] Dpdk: add symmetric_mp test #3629
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
working symmetric_mp for mana and mlx save state more symmetric_mp Dpdk: use more memory Dpdk: symmetric_mp test use debug messages for status Dpdk: move symmetric_mp to dpdkutil to allow rescind/non versions Dpdk: symmetric_mp polishing
mcgov
commented
Feb 5, 2025
| @@ -103,6 +104,58 @@ def verify_dpdk_build_netvsc( | |||
| node, log, variables, "netvsc", HugePageSize.HUGE_2MB, result=result | |||
| ) | |||
|
|
|||
| @TestCaseMetadata( | |||
| description=""" | |||
| netvsc pmd version. | |||
There was a problem hiding this comment.
Ooops. Need a real description here and below. Will fix
mcgov
commented
Feb 5, 2025
| # copy devname application into the examples directory | ||
| devname_local_folder = PurePath(__file__).parent.joinpath("devname") | ||
| self._node.shell.mkdir( | ||
| self.asset_path.joinpath("examples/devname"), parents=False, exist_ok=False |
There was a problem hiding this comment.
I might not want to have exist_ok=False? But it would be a good check if I end up trying to build DPDK twice without wiping the directory... Not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a runner for the DPDK example app
multiprocessing/symmetric_mp. This is another flavor of the multiprocessing test which can scale to a larger number of ports and processes than 'multiprocessing/client_server_mp'.Adding this test required a few smaller changes (and one refactor):
With these changes, the test itself is straightforward. We build and start the application; then use enable debug logging and check for the important DPDK netvsc PMD events that show the example app is working as expected.