dom0_kernel_installer: generate initramfs and use PARTUUID #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anirudhrb
reviewed
Mar 4, 2025
| shell=True, | ||
| expected_exit_code=0, | ||
| ).stdout.strip() | ||
| partuuid = node.execute( |
There was a problem hiding this comment.
No, lsblk tool does not fetch UUID and PARTUUID.
There was a problem hiding this comment.
Can you change lsblk to fetch the IDs?
There was a problem hiding this comment.
Changed lsblk tool fetch UUID and PARTUUID
squirrelsc
reviewed
Mar 4, 2025
anirudhrb
approved these changes
Mar 6, 2025
Fetch UUID for disks and UUID,PARTUUID for partitions. Also, add find_partition_by_mountpoint.
Using older initramfs does not work anymore as there are some kernel module dependencies. Hence, generate a new one. Also, replace UUID with PARTUUID since initramfs fails to understand the UUID. While at it, update validate() method to check if node's os is Mariner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using older initramfs does not work anymore as there are some kernel module dependencies. Hence, generate a new one. Also, replace UUID with PARTUUID since initramfs fails to understand the UUID.
While at it, update validate() method to check if node's os is Mariner.