Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] CVE-2025-26791 reported against DOMPurify 3.1.7 used in monaco-editor 0.52.2 #4844

Open
2 tasks done
kushalanand25 opened this issue Mar 3, 2025 · 2 comments
Open
2 tasks done

Comments

@kushalanand25
Copy link

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Link

NA

Monaco Editor Playground Code

NA

Reproduction Steps

NA

Actual (Problematic) Behavior

DOMPurify library 3.1.7 referenced in 0.52.2 version is having publicly reported CVE : https://nvd.nist.gov/vuln/detail/CVE-2025-26791
which has been fixed in below issue as part of DOMPurify 3.2.4 release.
cure53/DOMPurify#1064

Referenced DOMPurify version needs to updated in monaco editor to fix inherent vulnerability.

Expected Behavior

No response

Additional Context

No response

@hediet
Copy link
Member

hediet commented Mar 3, 2025

That CVE is about scenarios that use SAFE_FOR_TEMPLATES. We don't make use of that flag.

@kushalanand25
Copy link
Author

[Off topic maybe]
Is there a reason monaco-editor 0.52.2 refers to older 0.52.0-rc2 version of monaco-editor-core
https://github.com/microsoft/monaco-editor/blob/main/package.json#L55

And latest version of vscode is having DOMPurify 3.2.4 and no new version of monaco editor is released in recent time.
Given some dependencies are web-packed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants