Pad final GSO segment for CPU efficiency #4860
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfriesen
commented
Feb 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4860 +/- ##
==========================================
- Coverage 86.16% 86.06% -0.10%
==========================================
Files 56 56
Lines 17634 17630 -4
==========================================
- Hits 15195 15174 -21
- Misses 2439 2456 +17 ☔ View full report in Codecov by Sentry. |
…if at least one segment-sized buffer is preceding the current buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
Reduce goodput to potentially increase CPU efficiency by padding all GSO segments, including the final segment.
Testing
Do any existing tests cover this change? Are new tests needed?
CI.
Documentation
Is there any documentation impact for this change?
No.