Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Listener Callback for DoS Mode #4868

Merged
merged 10 commits into from
Mar 5, 2025
Merged

Add New Listener Callback for DoS Mode #4868

merged 10 commits into from
Mar 5, 2025

Conversation

vgmahajanshetty
Copy link
Contributor

@vgmahajanshetty vgmahajanshetty commented Feb 27, 2025

Description

Resolved #3717.
To support health probe, added new event for listeners. This event will be triggered for all opted in listeners.

Testing

Did basic tests manually.

Documentation

Is there any documentation impact for this change?

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.06%. Comparing base (618c860) to head (7de8330).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/core/listener.c 88.88% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4868      +/-   ##
==========================================
- Coverage   87.01%   86.06%   -0.96%     
==========================================
  Files          56       56              
  Lines       17685    17732      +47     
==========================================
- Hits        15389    15261     -128     
- Misses       2296     2471     +175     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgmahajanshetty vgmahajanshetty marked this pull request as ready for review February 28, 2025 15:56
nibanks
nibanks previously approved these changes Mar 5, 2025
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@nibanks
Copy link
Member

nibanks commented Mar 5, 2025

Looks like there are build failures. Please take a look.

@nibanks
Copy link
Member

nibanks commented Mar 5, 2025

You need to fix the Rust and C# layers too because of the API change.

@vgmahajanshetty vgmahajanshetty merged commit e458f15 into main Mar 5, 2025
370 of 377 checks passed
@vgmahajanshetty vgmahajanshetty deleted the task_3717 branch March 5, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support health probe
2 participants