Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: RegistrationConfig and CredentialConfig types #4881

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

youyuanwu
Copy link
Contributor

Description

Provide safe Rust wrapper for RegistrationConfig and CredentialConfig types.
Removed the manual ffi code respectively.
Replaced the crate feature switch schannel with openssl. This makes the rust code by default compiles with schannel on winodws unless openssl feature is enabled. For linux, openssl is the default.

Testing

Added tests for loading credentials for each credential types.

Documentation

NA

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.13%. Comparing base (ba9e8be) to head (ddc8e91).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4881      +/-   ##
==========================================
- Coverage   87.30%   87.13%   -0.17%     
==========================================
  Files          56       56              
  Lines       17630    17685      +55     
==========================================
+ Hits        15391    15410      +19     
- Misses       2239     2275      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@youyuanwu youyuanwu marked this pull request as ready for review March 3, 2025 06:51
@youyuanwu youyuanwu requested a review from a team as a code owner March 3, 2025 06:51
@nibanks nibanks added the Language: Rust Related to the Rust interop layer label Mar 3, 2025
nibanks
nibanks previously approved these changes Mar 3, 2025
@nibanks nibanks merged commit f5f8534 into microsoft:main Mar 6, 2025
394 of 396 checks passed
@youyuanwu youyuanwu deleted the users/youyuanwu/ffi-config-types branch March 6, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language: Rust Related to the Rust interop layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants