-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web] Shall we accept Uint16Array for 'float16' if Float16Array is available #23817
Labels
platform:web
issues related to ONNX Runtime web; typically submitted using template
Comments
This is indeed a problem. I think the behavior may need to be splitted into 2 discussions:
|
Ran into this issue myself too, which #23817 aims to fix (i.e., use Float16Array if available) |
amarin16
pushed a commit
that referenced
this issue
Mar 5, 2025
### Description Resolve #23817 ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
guschmue
pushed a commit
that referenced
this issue
Mar 6, 2025
### Description Resolve #23817 ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the issue
The
Float16Array
has been enabled by default in latest Chrome Canary, in ort-web, thefloat16
data type will be map toFloat16Array
at here now, while we are still usingUint16Array
as workaround input data, thus the code will go into following exception.This would break all apps that are still using
Uint16Array
as workaround forfloat16
, shall we accept bothUint16Array
andFloat16Array
for a period of time?@fs-eire, @guschmue
To reproduce
Create ORT float16 CPU tensor with Uint16Array data:
new ort.Tensor('float16', new Uint16Array([0]), [1]);
Urgency
No response
ONNX Runtime Installation
Released Package
ONNX Runtime Version or Commit ID
1.20.1
Execution Provider
'wasm'/'cpu' (WebAssembly CPU)
The text was updated successfully, but these errors were encountered: