New issue

Jump to bottom

[IR] Create tensor adaptor for mlx #2060

Draft

justinchuby wants to merge 1 commit into microsoft:main from justinchuby:justinchu/mlx

Collaborator

justinchuby commented Feb 15, 2025

No description provided.


          [IR] Create tensor adaptor for mlx

e0b69f5

codecov bot commented Feb 15, 2025 •

edited

Loading

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 66.79%. Comparing base (dfee02e) to head (e0b69f5).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
onnxscript/ir/tensor_adapters.py	38.09%	13 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
- Coverage   72.21%   66.79%   -5.42%     
==========================================
  Files         215      215              
  Lines       28729    28746      +17     
  Branches     3412     3414       +2     
==========================================
- Hits        20747    19202    -1545     
- Misses       6861     8449    +1588     
+ Partials     1121     1095      -26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security bot found potential problems

View reviewed changes

onnxscript/ir/tensor_adapters.py

@@ @@ -39,14 +40,20 @@ @@
               from onnxscript import ir
               from onnxscript.ir import _core
+              import ml_dtypes

Check notice

Code scanning / lintrunner

PYLINT/C0411 Note

third party import "ml_dtypes" should be placed before first party imports "onnxscript.ir", "onnxscript.ir._core" (wrong-import-order)
See wrong-import-order. To disable, use # pylint: disable=wrong-import-order

onnxscript/ir/tensor_adapters.py

@@ @@ -39,14 +40,20 @@ @@
               from onnxscript import ir
               from onnxscript.ir import _core
+              import ml_dtypes

Check warning

Code scanning / lintrunner

PYLINT/W0611 Warning

Unused import ml_dtypes (unused-import)
See unused-import. To disable, use # pylint: disable=unused-import

onnxscript/ir/tensor_adapters.py

@@ @@ -39,14 +40,20 @@ @@
               from onnxscript import ir
               from onnxscript.ir import _core
+              import ml_dtypes

Check warning

Code scanning / lintrunner

RUFF/F401 Warning

ml\_dtypes imported but unused.
See https://docs.astral.sh/ruff/rules/unused-import

onnxscript/ir/tensor_adapters.py

@@ @@ -39,14 +40,20 @@ @@
               from onnxscript import ir
               from onnxscript.ir import _core
+              import ml_dtypes
+              import numpy as np

Check notice

Code scanning / lintrunner

PYLINT/C0411 Note

third party import "numpy" should be placed before first party imports "onnxscript.ir", "onnxscript.ir._core" (wrong-import-order)
See wrong-import-order. To disable, use # pylint: disable=wrong-import-order

onnxscript/ir/tensor_adapters.py

@@ @@ -39,14 +40,20 @@ @@
               from onnxscript import ir
               from onnxscript.ir import _core
+              import ml_dtypes
+              import numpy as np

Check notice

Code scanning / lintrunner

PYLINT/C0412 Note

Imports from package numpy are not grouped (ungrouped-imports)
See ungrouped-imports. To disable, use # pylint: disable=ungrouped-imports

onnxscript/ir/tensor_adapters.py

               if TYPE_CHECKING:
                   import torch
+                  import mlx.core as mx

Check failure

Code scanning / lintrunner

MYPY/import-not-found Error

Cannot find implementation or library stub for module named "mlx.core" To disable, use # type: ignore[import-not-found]

onnxscript/ir/tensor_adapters.py

               if TYPE_CHECKING:
                   import torch
+                  import mlx.core as mx

Check failure

Code scanning / lintrunner

MYPY/import-not-found Error

Cannot find implementation or library stub for module named "mlx" To disable, use # type: ignore[import-not-found]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet