fix: fix Conntrack GC running in Retina default

[manojks1999]

Description

Please provide a brief description of the changes made in this pull request.

Related Issue

#1314

Below are changes made in current PR:

• Added a condition of check before creating a instance
• Check is made by the configs of instance
• Added with appropriate log

Checklist

• [ * ] I have read the contributing documentation.
• [ * ] I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
• [ * ] I have correctly attributed the author(s) of the code.
• [ * ] I have tested the changes locally.
• [ * ] I have followed the project's style guidelines.
• [ * ] I have updated the documentation, if necessary.
• [ * ] I have added tests, if applicable.

[manojks1999]

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

[SRodi]

Hi @manojks1999, thanks for opening this PR! Can you please fix all unsuccessful checks? If needed you can "convert to draft" and then switch to "ready for review" once you are done.

[manojks1999]

@SRodi , I have fixed the runtime build, able to create a make file locally, but unable to create a docker file as some dependency issue in config.

[manojks1999]

@SRodi, I have made changes now we are getting the correct output,

ts=2025-02-08T16:22:14.299Z level=info caller=conntrack/conntrack_linux.go:101 msg="Skipping Conntrack GC loop as packetparser plugin is not enabled"

Please verify once and also can you provide command related to helm install
with respect to packetparser both enabled and disabled, so that I can test your command too, so that have a extra verification.

[manojks1999]

@SRodi Added a set method for the widows files too.

[SRodi]

@manojks1999 Thanks for looking into this. I don't think we want and/or is necessary to add the config to Conntrack struct. Have you looked into adding a conditional when we start Conntrack?

retina/pkg/managers/pluginmanager/pluginmanager.go

Lines 140 to 141 in 819a9ee

	// run conntrack GC
	ct, err := conntrack.New()

Also, for development environment set up instructions please see this doc https://retina.sh/docs/Contributing/development

Make sure this is tested and you add test results (or screenshots) to the PR description when possible. Please also provide a clear description for this PR.

I'll mark this PR as draft for now, once you have all bits in order, please feel free to change it to "Ready to review". Thanks again!

[SRodi]

By removing the function isPluginEnables you should also be able to fix the existing golint errors on receiver name and shadow declaration.

Error: pkg/managers/pluginmanager/pluginmanager.go:214:1: receiver-naming: receiver name pm should be consistent with previous receiver name p for PluginManager (revive)
  func (pm *PluginManager) isPluginEnabled(name string) bool {
  	if pm.cfg.EnabledPlugin == nil {
  		return false
  	}
  	for _, plugin := range pm.cfg.EnabledPlugin {
  		if plugin == name {
  			return true
  		}
  	}
  	return false
  }
  Error: pkg/managers/pluginmanager/pluginmanager.go:1[42](https://github.com/microsoft/retina/actions/runs/13476073474/job/37767750405?pr=1323#step:4:44):7: shadow: declaration of "err" shadows declaration at line 119 (govet)
  		ct, err := conntrack.New()
  		    ^

[manojks1999]

@SRodi made a changes with variable names

[SRodi]

LGTM but I'd like @nddq to also take a look/approve. Please @manojks1999 also update the branch based on latest main.

[nddq]

@manojks1999 please sign the commits so we can merge this, thanks!

[manojks1999]

@manojks1999 please sign the commits so we can merge this, thanks!

Sure will do that

[manojks1999]

@manojks1999 please sign the commits so we can merge this, thanks!

Sure will do that

@nddq Done with signing all existing commits

[SRodi]

LGTM, thanks @manojks1999!