-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change mounting path in retina-agent from /var/run to /var/run/cilium #1389
base: main
Are you sure you want to change the base?
Conversation
deploy/hubble/manifests/controller/helm/retina/templates/agent/daemonset.yaml
Outdated
Show resolved
Hide resolved
deploy/hubble/manifests/controller/helm/retina/templates/agent/daemonset.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add test results?
- Is Hubble control plane working with these changes?
- Can you see flows served on
unix:///var/run/cilium/hubble.sock
?
deploy/hubble/manifests/controller/helm/retina/templates/agent/daemonset.yaml
Outdated
Show resolved
Hide resolved
deploy/hubble/manifests/controller/helm/retina/templates/agent/daemonset.yaml
Outdated
Show resolved
Hide resolved
deploy/hubble/manifests/controller/helm/retina/templates/agent/daemonset.yaml
Outdated
Show resolved
Hide resolved
c5f995b
to
82370c4
Compare
@anubhabMajumdar I added an image of flows that I had forgotten before. Is that enough or is there any further detail that you want to check? |
deploy/hubble/manifests/controller/helm/retina/templates/agent/daemonset.yaml
Outdated
Show resolved
Hide resolved
You can try |
82370c4
to
98bcbb7
Compare
|
043cd54
to
4d02dc7
Compare
…ilium Signed-off-by: Alex Castilio dos Santos <alexsantos@microsoft.com>
4d02dc7
to
ec0e2a4
Compare
Signed-off-by: Alex Castilio dos Santos <alexsantos@microsoft.com>
ec0e2a4
to
888b004
Compare
Description
Change mounting path in retina-agent from /var/run to /var/run/cilium
Related Issue
#1386
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Flows:

Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.