Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary parser errors which disallow syft SBOMs #917

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

sfoslund
Copy link
Member

@sfoslund sfoslund commented Feb 3, 2025

This PR removes 2 SPDX 2.2 parser exceptions which are currently enforcing rules which are not explicitly required for SPDX 2.2 SBOMs. These errors have not been a problem thus far because the SBOMs generated by this tool (currently the only type of SBOM we parse with the parser package) do not violate these assumptions. However, when we start parsing SBOMs generated by syft, we need to allow for more variance. These changes include:

@sfoslund sfoslund requested a review from a team as a code owner February 3, 2025 17:34
@sfoslund
Copy link
Member Author

sfoslund commented Feb 3, 2025

/azp run

@sfoslund
Copy link
Member Author

sfoslund commented Feb 3, 2025

Ignore the last commit, just pushed an empty commit to retrigger the CLI check that was stuck

@sfoslund
Copy link
Member Author

sfoslund commented Feb 3, 2025

/azp run

@sfoslund sfoslund merged commit b943a0f into main Feb 3, 2025
4 checks passed
@sfoslund sfoslund deleted the sfoslund/syft branch February 3, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants