Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MSBuild Logging APIs for Task output instead of StdOut #933

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Use MSBuild Logging APIs for Task output instead of StdOut #933

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6f3cfc0
Add MSBuild logger
sfoslund Sep 26, 2024
7b90dd4
Sidestep a timing issue with the TaskLoggingHelper in the GenerateSbo…
baronfel Oct 1, 2024
9a3c6ae
Ensure that for all TFMs we can infer a verbosity and apply it to the…
baronfel Feb 16, 2025
1314672
remove unused code
baronfel Feb 16, 2025
3b8ebf0
reduce verbosity of pre-existing folder check to prevent errant MSBui…
baronfel Feb 23, 2025
7348891
respond to review feedback
baronfel Feb 23, 2025
5ccacf9
respond to some logging feedback
baronfel Feb 26, 2025
8617f34
disable component detection summary
baronfel Feb 27, 2025
1da2e9c
transform component detection warnings into information because they …
baronfel Feb 27, 2025
179a4f9
Fix infinite loop
baronfel Feb 28, 2025
aa37566
fix rewriting detection
baronfel Feb 28, 2025
649d0fc
Keep some of the previous API surface area to minimize breaks. Add do…
baronfel Mar 1, 2025
5815ef3
fix potential nonexistent dictionary access
baronfel Mar 1, 2025
7cd5025
Elevate Microsoft.Extensions.Options to a direct dependency to preven…
baronfel Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reduce verbosity of pre-existing folder check to prevent errant MSBui… 
…ld warnings.
  • Loading branch information
@baronfel
baronfel committed Mar 1, 2025
commit 3b8ebf0cb7c8775d981eed33f967e8119a56fcf7
4 changes: 2 additions & 2 deletions src/Microsoft.Sbom.Api/Workflows/SbomGenerationWorkflow.cs
View file
Original file line number Diff line number Diff line change
@@ -150,7 +150,7 @@ public virtual async Task<bool> RunAsync()
recorder.RecordTotalErrors(validErrors);
}

// Delete the generated _manifest folder if generation failed.
// Delete the generated _manifest folder if generation failed.
if (deleteSbomDir || validErrors.Any())
{
DeleteManifestFolder(sbomDir);
@@ -242,7 +242,7 @@ private void RemoveExistingManifestDirectory()
$"overwrite this folder.");
}

log.Warning(
log.Information(
$"Deleting pre-existing folder {rootManifestFolderPath} as {Constants.DeleteManifestDirBoolVariableName}" +
$" is 'true'.");
fileSystemUtils.DeleteDir(rootManifestFolderPath, true);