respond to some logging feedback

src/Microsoft.Sbom.Targets/GenerateSbomTask.cs

@@ -39,16 +39,14 @@ public override bool Execute()
     {
         try
         {
-            var taskLoggingHelper = new TaskLoggingHelper(this);
-
             // Validate required args and args that take paths as input.
             if (!ValidateAndSanitizeRequiredParams() || !ValidateAndSanitizeNamespaceUriUniquePart())
             {
                 return false;
             }
 
             var logVerbosity = ValidateAndAssignVerbosity();
-            var msbuildLogger = new MSBuildLogger(taskLoggingHelper);
+            var msbuildLogger = new MSBuildLogger(this.Log);
             Serilog.Log.Logger = msbuildLogger;
             var taskHost = Host.CreateDefaultBuilder()
                .ConfigureServices((host, services) =>
@@ -115,15 +113,27 @@ public override bool Execute()
 
             foreach (var error in result.Errors)
             {
-                Log.LogMessage(MessageImportance.Normal, "{0}({1}) - {2} - {3}", error.Entity.Id, error.Entity.EntityType, error.ErrorType, error.Details);
+                var file = error.Entity is FileEntity fe ? fe.Path : null;
+                Log.LogMessage(
+                    subcategory: null,
+                    code: null,
+                    helpKeyword: null,
+                    file: file,
+                    lineNumber: 0,
+                    columnNumber: 0,
+                    endLineNumber: 0,
+                    endColumnNumber: 0,
+                    importance: MessageImportance.Normal,
+                    message: "{0}({1}) - {2} - {3}",
+                    messageArgs: [error.Entity.Id, error.Entity.EntityType, error.ErrorType, error.Details]);
             }
 
             return result.IsSuccessful;
         }
         catch (Exception e)
         {
             Log.LogError($"SBOM generation failed: {e.Message}");
-            return Log.HasLoggedErrors;
+            return !Log.HasLoggedErrors;
         }
     }