-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API BREAKING CHANGE: Remove back-compat interface shims #952
Conversation
Note that the concretion classes will end up in a different folder after the SPDX 3.0 changes land
/azp run |
src/Microsoft.Sbom.Api/Executors/ComponentDetectionBaseWalker.cs
Outdated
Show resolved
Hide resolved
This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:
Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following: Option 1 - Publish this as a breaking change
Option 2 - Refactor the changes to be non-breaking
|
/azp run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love being able to delete all this code!
We added the
IConfiguration2
andILicenseInformationFetcher2
interfaces to maintain backward compatibility with the 3.0 API interface. Since the 4.0 API interface is a breaking change, we can remove the 2 shim interfaces for simplicity.