Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API BREAKING CHANGE: Remove back-compat interface shims #952

Merged
merged 4 commits into from
Mar 3, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Minimize diff noise
  • Loading branch information
DaveTryon committed Mar 3, 2025
commit 165288946e7b6abe12f220cde98c47358200f04e
16 changes: 8 additions & 8 deletions src/Microsoft.Sbom.Api/Executors/ILicenseInformationFetcher.cs
Original file line number Diff line number Diff line change
@@ -17,6 +17,14 @@ public interface ILicenseInformationFetcher
/// <returns></returns>
List<string> ConvertComponentsToListForApi(IEnumerable<ScannedComponent> scannedComponents);

/// <summary>
/// Calls the ClearlyDefined API to get the license information for the list of components.
/// </summary>
/// <param name="listOfComponentsForApi"> A list of strings formatted into a list of strings that can be used to call the batch ClearlyDefined API.</param>
/// <param name="timeoutInSeconds">Timeout in seconds to use when making web requests. Caller owns sanitizing this value</param>
/// <returns></returns>
Task<List<string>> FetchLicenseInformationAsync(List<string> listOfComponentsForApi, int timeoutInSeconds);

/// <summary>
/// Gets the dictionary of licenses that were fetched from the ClearlyDefined API.
/// </summary>
@@ -43,12 +51,4 @@ public interface ILicenseInformationFetcher
/// <param name="key">The "name@version" of a component.</param>
/// <returns></returns>
public string GetFromLicenseDictionary(string key);

/// <summary>
/// Calls the ClearlyDefined API to get the license information for the list of components.
/// </summary>
/// <param name="listOfComponentsForApi"> A list of strings formatted into a list of strings that can be used to call the batch ClearlyDefined API.</param>
/// <param name="timeoutInSeconds">Timeout in seconds to use when making web requests. Caller owns sanitizing this value</param>
/// <returns></returns>
Task<List<string>> FetchLicenseInformationAsync(List<string> listOfComponentsForApi, int timeoutInSeconds);
}