Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud Events - new Step type dedicated to work as Proxy Step abstraction #10328

Closed
esttenorio opened this issue Jan 28, 2025 · 0 comments · Fixed by #10477
Closed

Cloud Events - new Step type dedicated to work as Proxy Step abstraction #10328

esttenorio opened this issue Jan 28, 2025 · 0 comments · Fixed by #10477
Assignees
@esttenorio
Labels
sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@esttenorio
Copy link
Contributor

To avoid passing IExternalKernelProcessMessageChannel to all steps, create new step like type so when on creating LocalProcess or DaprProcessActor the external kernel process message channel get passed only to new step like type.

This will help to avoid sharing resources to steps that shouldn't know/have access about/to specific service resources.
@sophialagerkranspandey sophialagerkranspandey added sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) and removed triage labels Jan 30, 2025
@esttenorio esttenorio mentioned this issue Feb 11, 2025
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 5, 2025
@esttenorio
.Net: Process Cloud Events - Publish Events Abstractions (#10477)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
7502712 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

#### Changes

- more plumbing:
   - piping source event name info when emitting an event
   - capturing event name when linking step/process edges
- creating new step family components - _ProxyStep_ (following similar
pattern used for MapStep by @crickman )
   - ProcessProxyBuilder
   - KernelProcessProxy
   - LocalProxy
   - ProxyActor/IProxy/DaprProxyInfo
 - updating process cloud events uts
 - adding new uts in 

Fixes #10328 

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esttenorio esttenorio

Labels
sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.Net: Process Cloud Events - Publish Events Abstractions esttenorio/semantic-kernel
3 participants
@esttenorio @markwallace-microsoft @sophialagerkranspandey