Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net Agents - Mark experimental features #10535

Closed
crickman opened this issue Feb 13, 2025 · 2 comments · Fixed by #10600
Closed

.Net Agents - Mark experimental features #10535

crickman opened this issue Feb 13, 2025 · 2 comments · Fixed by #10600
Assignees
@crickman
Labels
agents feature_graduation Applied to all feature graduation issues .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@crickman
Copy link
Contributor

As part of agent graduation, move the experimental declaration from the project level to specific features that are not graduating:

  • AgentChat/AgentGroupChat: The existing multi-agent chat.
  • AgentChannel: The channel construct only exists to enable multi-agent chat.
  • AggregatorAgent: In its current form, this agent is intrinsically bound to AgentChat.
  • AgentChatSerializer: This exists as an outgrowth of AgentChat and is not conducive to distributed patterns.
  • Agent: The base abstraction defines three methods that are not associated with patterns being graduated:
    1. GetChannelKeys
    2. CreateChannelAsync
    3. RestoreChannelAsync
@crickman crickman added .NET Issue or Pull requests regarding .NET code agents feature_graduation Applied to all feature graduation issues triage labels Feb 13, 2025
@crickman crickman self-assigned this Feb 13, 2025
@crickman crickman removed the triage label Feb 13, 2025
@shethaadit
Copy link
Contributor

Hi @crickman / @markwallace-microsoft, I will raise PR for this soon. :)

@shethaadit shethaadit mentioned this issue Feb 13, 2025
Closed
4 tasks
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Feb 18, 2025
@crickman crickman mentioned this issue Feb 19, 2025
Merged
4 tasks
@crickman crickman moved this to Sprint: In Review in Semantic Kernel Feb 19, 2025
@crickman crickman linked a pull request Feb 19, 2025 that will close this issue
.Net Agents: Update experimental meta-data for graduation #10600
Merged
4 tasks
@crickman
Copy link
Contributor Author

Hi @crickman / @markwallace-microsoft, I will raise PR for this soon. :)

Thanks, I've got it covered: #10600

github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2025
@crickman @markwallace-microsoft @alliscode
.Net Agents: Update experimental meta-data for graduation (#10600)
9401760 
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

As part of Agent Graduation, the `Experimental` attributes must be more
precisely defined.

- Fixes: #10535
- Fixes: #10303

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

Apply `Experimental` attributes for non-graduating artifacts for:

- `Microsoft.SementicKernel.Agents.Abstractions`
- `Microsoft.SementicKernel.Agents.Core`
- `Microsoft.SementicKernel.Agents.OpenAI`

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄

---------

Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
Co-authored-by: Ben Thomas <bentho@microsoft.com>
Co-authored-by: Ben Thomas <ben.thomas@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crickman crickman

Labels
agents feature_graduation Applied to all feature graduation issues .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Status: Sprint: In Review
Milestone
No milestone
3 participants
@shethaadit @evchaki @crickman