Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Bug: dotnet notebooks require .net 9 SDK #10715

Closed
ross-p-smith opened this issue Feb 27, 2025 · 1 comment
Closed

.Net: Bug: dotnet notebooks require .net 9 SDK #10715

ross-p-smith opened this issue Feb 27, 2025 · 1 comment
Labels
bug Something isn't working .NET Issue or Pull requests regarding .NET code

Comments

@ross-p-smith
Copy link
Contributor

Describe the bug
Following the dotnet getting started guide, it states to install .Net 8 and the devcontainer installs dotnet 8. However the Notebooks require dotnet 9

Expected behavior
The Notebooks work in VSCode DevContainer straight after cloning.

Platform

  • C#
  • VS Code
  • Windows

Additional context
DevContainer
@ross-p-smith ross-p-smith added the bug Something isn't working label Feb 27, 2025
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code triage labels Feb 27, 2025
@github-actions github-actions bot changed the title Bug: dotnet notebooks require .net 9 SDK .Net: Bug: dotnet notebooks require .net 9 SDK Feb 27, 2025
This was referenced Feb 27, 2025
Closed
Merged
@sophialagerkranspandey
Copy link
Contributor

@ross-p-smith , we've added this to the backlog as it's not a breaking issue and there are a lot of customers on .net 8 still.

github-merge-queue bot pushed a commit that referenced this issue Mar 4, 2025
@ross-p-smith
.Net: dotnet format issues with SDK 9.0 (#10741)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
022f05e 
### Motivation and Context
In order to be able to build the dotnet code with version 9 SDK, there
were some problems with the following file


`/workspaces/semantic-kernel/dotnet/src/InternalUtilities/src/Diagnostics/ActivityExtensions.cs`.
This had a BOM encoding problem which was causing `dotnet format` to
fail. As seen in this Issue
[https://github.com/dotnet/sdk/issues/46780](https://github.com/dotnet/sdk/issues/46780).

I fixed the encoding and formatting issues ready for version 9. Most of
the formatting issues are around removing the access modifiers on
interface members

This relates to #10715
### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
rracanicci pushed a commit to rracanicci/semantic-kernel that referenced this issue Mar 5, 2025
@ross-p-smith @rracanicci
.Net: dotnet format issues with SDK 9.0 (microsoft#10741)
ca858d1 
### Motivation and Context
In order to be able to build the dotnet code with version 9 SDK, there
were some problems with the following file


`/workspaces/semantic-kernel/dotnet/src/InternalUtilities/src/Diagnostics/ActivityExtensions.cs`.
This had a BOM encoding problem which was causing `dotnet format` to
fail. As seen in this Issue
[https://github.com/dotnet/sdk/issues/46780](https://github.com/dotnet/sdk/issues/46780).

I fixed the encoding and formatting issues ready for version 9. Most of
the formatting issues are around removing the access modifiers on
interface members

This relates to microsoft#10715
### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.Net: Upgrade dotnet sdk 9 ross-p-smith/semantic-kernel
3 participants
@ross-p-smith @markwallace-microsoft @sophialagerkranspandey