Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: ConditionalTheory attribute does not work as expected #10736

Open
adamsitnik opened this issue Feb 28, 2025 · 0 comments
Open

.Net: ConditionalTheory attribute does not work as expected #10736

adamsitnik opened this issue Feb 28, 2025 · 0 comments
Assignees
Labels
.NET Issue or Pull requests regarding .NET code

Comments

@adamsitnik
Copy link
Member

The attribute points to the fact discoverer, while it should point to a theory discoverer:

[XunitTestCaseDiscoverer("VectorDataSpecificationTests.Xunit.VectorStoreFactDiscoverer", "VectorDataIntegrationTests")]
public sealed class ConditionalTheoryAttribute : TheoryAttribute;

I took a quick look at how it's implemented by Microsoft.DotNet.XUnitExtensions and got to the conclusion that I won't fix that in my current PR (too much noise, I want to get it merged)

https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.XUnitExtensions/src/Discoverers/ConditionalTheoryDiscoverer.cs

Should we just take a dependency on Microsoft.DotNet.XUnitExtensions ?

cc @roji @westey-m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

No branches or pull requests

3 participants