You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I took a quick look at how it's implemented by Microsoft.DotNet.XUnitExtensions and got to the conclusion that I won't fix that in my current PR (too much noise, I want to get it merged)
The attribute points to the fact discoverer, while it should point to a theory discoverer:
semantic-kernel/dotnet/src/VectorDataIntegrationTests/VectorDataIntegrationTests/Xunit/ConditionalTheoryAttribute.cs
Lines 9 to 10 in 3a36d40
I took a quick look at how it's implemented by
Microsoft.DotNet.XUnitExtensions
and got to the conclusion that I won't fix that in my current PR (too much noise, I want to get it merged)https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.XUnitExtensions/src/Discoverers/ConditionalTheoryDiscoverer.cs
Should we just take a dependency on
Microsoft.DotNet.XUnitExtensions
?cc @roji @westey-m
The text was updated successfully, but these errors were encountered: