Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: document region setup for Bedrock #9910

Closed
eavanvalkenburg opened this issue Dec 9, 2024 · 4 comments · Fixed by #10772
Closed

Python: document region setup for Bedrock #9910

eavanvalkenburg opened this issue Dec 9, 2024 · 4 comments · Fixed by #10772
Assignees
@TaoChenOSU
Labels
ai connector Anything related to AI connectors python Pull requests for the Python Semantic Kernel sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@eavanvalkenburg
Copy link
Member

No description provided.

@eavanvalkenburg eavanvalkenburg converted this from a draft issue Dec 9, 2024
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel triage labels Dec 9, 2024
@alliscode alliscode removed the triage label Dec 9, 2024
@alliscode
Copy link
Member

@eavanvalkenburg is this issue for yourself? I've assigned to you for now.

@TaoChenOSU
Copy link
Contributor

We already have a README on how to set up the bedrock service, including region. Please provide more details on this task @eavanvalkenburg, thanks!

@eavanvalkenburg
Copy link
Member Author

The reason I created this issue is because I got an error that Region wasn't set, but then when I look at the init signature of the Bedrock Chat Completion there is no way to set the region, so either we add a note on that in the init or a link to the Readme in there, and I think it also helps to write out the region setup directly in the readme, rather then just having a link, I do see that region_name is a supported arg in the underlying client, so adding Kwargs to BedrockChatCompletion with a pointer to the boto client would also help, as well as adding region to the settings of Bedrock, since it doesn't work without it and it is often something that should be driven by environment settings.

@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Dec 17, 2024
@moonbox3
Copy link
Contributor

@TaoChenOSU is there still pending work here?

@moonbox3 moonbox3 added the ai connector Anything related to AI connectors label Feb 18, 2025
@TaoChenOSU TaoChenOSU mentioned this issue Mar 3, 2025
Merged
4 tasks
@TaoChenOSU TaoChenOSU linked a pull request Mar 3, 2025 that will close this issue
Python: Improve Bedrock service setup docs #10772
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 4, 2025
@TaoChenOSU
Python: Improve Bedrock service setup docs (#10772)
8fd6da2 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Closing: #9910

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
1. Add detailed instructions on how to setup one's environment to use
Bedrock services, including models and agents.
2. Re-enable bedrock integration tests.
3. Some other cleanups.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
rracanicci pushed a commit to rracanicci/semantic-kernel that referenced this issue Mar 5, 2025
@TaoChenOSU @rracanicci
Python: Improve Bedrock service setup docs (microsoft#10772)
c3f1abd 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Closing: microsoft#9910

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
1. Add detailed instructions on how to setup one's environment to use
Bedrock services, including models and agents.
2. Re-enable bedrock integration tests.
3. Some other cleanups.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TaoChenOSU TaoChenOSU

Labels
ai connector Anything related to AI connectors python Pull requests for the Python Semantic Kernel sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Python: Improve Bedrock service setup docs TaoChenOSU/semantic-kernel-fork
6 participants
@TaoChenOSU @eavanvalkenburg @alliscode @moonbox3 @evchaki @markwallace-microsoft